You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/02/24 01:15:16 UTC

Review Request 57012: Added unit tests for SHARE and UNSHARE offer operations.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57012/
-----------------------------------------------------------

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-7128
    https://issues.apache.org/jira/browse/MESOS-7128


Repository: mesos


Description
-------

Added unit tests for SHARE and UNSHARE offer operations.


Diffs
-----

  src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a 
  src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31 
  src/tests/mesos.hpp b450a04dfbf3bbeeb6b605fb78097dca390cbdbe 
  src/tests/persistent_volume_tests.cpp 7ac82862363af7a33a52b8570149cf2237b3519b 

Diff: https://reviews.apache.org/r/57012/diff/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Re: Review Request 57012: Added unit tests for SHARE and UNSHARE offer operations.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57012/#review167244
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57010, 57011, 57012]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 1, 2017, 7:58 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57012/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 7:58 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7128
>     https://issues.apache.org/jira/browse/MESOS-7128
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit tests for SHARE and UNSHARE offer operations.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp cdf1f15b7802439b28405ca8f6634ce83e886630 
>   src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7 
>   src/tests/mesos.hpp b450a04dfbf3bbeeb6b605fb78097dca390cbdbe 
>   src/tests/persistent_volume_tests.cpp 7ac82862363af7a33a52b8570149cf2237b3519b 
> 
> 
> Diff: https://reviews.apache.org/r/57012/diff/2/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Re: Review Request 57012: Added unit tests for SHARE and UNSHARE offer operations.

Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57012/
-----------------------------------------------------------

(Updated Feb. 28, 2017, 11:58 p.m.)


Review request for mesos and Jiang Yan Xu.


Changes
-------

Rebased.


Bugs: MESOS-7128
    https://issues.apache.org/jira/browse/MESOS-7128


Repository: mesos


Description
-------

Added unit tests for SHARE and UNSHARE offer operations.


Diffs (updated)
-----

  src/tests/hierarchical_allocator_tests.cpp cdf1f15b7802439b28405ca8f6634ce83e886630 
  src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7 
  src/tests/mesos.hpp b450a04dfbf3bbeeb6b605fb78097dca390cbdbe 
  src/tests/persistent_volume_tests.cpp 7ac82862363af7a33a52b8570149cf2237b3519b 

Diff: https://reviews.apache.org/r/57012/diff/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Re: Review Request 57012: Added unit tests for SHARE and UNSHARE offer operations.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57012/#review166639
-----------------------------------------------------------



Patch looks great!

Reviews applied: [57010, 57011, 57012]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 24, 2017, 1:15 a.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57012/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2017, 1:15 a.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7128
>     https://issues.apache.org/jira/browse/MESOS-7128
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added unit tests for SHARE and UNSHARE offer operations.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a 
>   src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31 
>   src/tests/mesos.hpp b450a04dfbf3bbeeb6b605fb78097dca390cbdbe 
>   src/tests/persistent_volume_tests.cpp 7ac82862363af7a33a52b8570149cf2237b3519b 
> 
> Diff: https://reviews.apache.org/r/57012/diff/
> 
> 
> Testing
> -------
> 
> All tests passed.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>