You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/02/11 00:45:21 UTC
Review Request 56568: Modified the executor driver to always relink
on agent failover.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56568/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-7057
https://issues.apache.org/jira/browse/MESOS-7057
Repository: mesos
Description
-------
A relink is needed in cases where a netfilter module like iptables
can terminate the connection without notifying the executor. This
results in the executor still trying to reuse the stale "half-open"
connection upon receiving the reconnect message from the executor
leading to the erroneous behavior.
Diffs
-----
src/exec/exec.cpp 95c2e19f06c1778bd837247fc96d46d32b53c00b
Diff: https://reviews.apache.org/r/56568/diff/
Testing
-------
Performed the steps to reproduce on MESOS-5332 and verified the problem is fixed with the relink.
Thanks,
Anand Mazumdar
Re: Review Request 56568: Modified the executor driver to always
relink on agent failover.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56568/#review165219
-----------------------------------------------------------
Ship it!
+1 for fewer executor deaths during agent recovery (the agent gives 2 seconds for the executor to respond to the reconnect message before killing the executor).
- Joseph Wu
On Feb. 10, 2017, 4:45 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56568/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 4:45 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7057
> https://issues.apache.org/jira/browse/MESOS-7057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A relink is needed in cases where a netfilter module like iptables
> can terminate the connection without notifying the executor. This
> results in the executor still trying to reuse the stale "half-open"
> connection upon receiving the reconnect message from the executor
> leading to the erroneous behavior.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 95c2e19f06c1778bd837247fc96d46d32b53c00b
>
> Diff: https://reviews.apache.org/r/56568/diff/
>
>
> Testing
> -------
>
> Performed the steps to reproduce on MESOS-5332 and verified the problem is fixed with the relink.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56568: Modified the executor driver to always
relink on agent failover.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56568/#review165243
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56568]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 11, 2017, 12:45 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56568/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2017, 12:45 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7057
> https://issues.apache.org/jira/browse/MESOS-7057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A relink is needed in cases where a netfilter module like iptables
> can terminate the connection without notifying the executor. This
> results in the executor still trying to reuse the stale "half-open"
> connection upon receiving the reconnect message from the executor
> leading to the erroneous behavior.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 95c2e19f06c1778bd837247fc96d46d32b53c00b
>
> Diff: https://reviews.apache.org/r/56568/diff/
>
>
> Testing
> -------
>
> Performed the steps to reproduce on MESOS-5332 and verified the problem is fixed with the relink.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 56568: Modified the executor driver to always
relink on agent failover.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56568/#review165224
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 11, 2017, 12:45 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56568/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2017, 12:45 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7057
> https://issues.apache.org/jira/browse/MESOS-7057
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A relink is needed in cases where a netfilter module like iptables
> can terminate the connection without notifying the executor. This
> results in the executor still trying to reuse the stale "half-open"
> connection upon receiving the reconnect message from the executor
> leading to the erroneous behavior.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp 95c2e19f06c1778bd837247fc96d46d32b53c00b
>
> Diff: https://reviews.apache.org/r/56568/diff/
>
>
> Testing
> -------
>
> Performed the steps to reproduce on MESOS-5332 and verified the problem is fixed with the relink.
>
>
> Thanks,
>
> Anand Mazumdar
>
>