You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/02/06 23:14:39 UTC
Review Request 56351: Renamed a private member function in DRFSorter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56351/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Renamed `update(const string&)` to `updateShare(const string&)`. The
sorter interface already includes two different member functions named
`update` that do different things, so being a bit more explicit seems
helpful.
Diffs
-----
src/master/allocator/sorter/drf/sorter.hpp 5bed53a1641fee0c09862f77b394a0e9ec131990
src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56351/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56351: Renamed a private member function in
DRFSorter.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56351/#review164604
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 6, 2017, 3:14 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56351/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 3:14 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Renamed `update(const string&)` to `updateShare(const string&)`. The
> sorter interface already includes two different member functions named
> `update` that do different things, so being a bit more explicit seems
> helpful.
>
>
> Diffs
> -----
>
> src/master/allocator/sorter/drf/sorter.hpp 5bed53a1641fee0c09862f77b394a0e9ec131990
> src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
>
> Diff: https://reviews.apache.org/r/56351/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>