You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@apache.org> on 2017/02/11 01:07:36 UTC
Review Request 56569: Updated `drop` log message from `ERROR` to
`WARNING`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56569/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Updated `drop` log message from `ERROR` to `WARNING`.
Diffs
-----
src/master/master.cpp 80d481b2ea1435147cd213383008435f35112d92
Diff: https://reviews.apache.org/r/56569/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 56569: Made ignoring logging use WARNING in master.
Posted by Guangya Liu <gy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56569/
-----------------------------------------------------------
(Updated \u4e8c\u6708 11, 2017, 1:52 a.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Updated commit message and also more ignore log message use WARNING.
Summary (updated)
-----------------
Made ignoring logging use WARNING in master.
Repository: mesos
Description (updated)
-------
Made ignoring logging use WARNING in master.
Diffs (updated)
-----
src/master/master.cpp 0cf81adeb1d087f298a9c70cfb40179ad457bed2
Diff: https://reviews.apache.org/r/56569/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 56569: Updated `drop` log message from `ERROR` to
`WARNING`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56569/#review165226
-----------------------------------------------------------
Ship it!
I didn't do an audit but you should probably look to see if our existing message ignoring logging (not all of them use drop) use WARNING.
- Benjamin Mahler
On Feb. 11, 2017, 1:07 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56569/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2017, 1:07 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `drop` log message from `ERROR` to `WARNING`.
>
>
> Diffs
> -----
>
> src/master/master.cpp 80d481b2ea1435147cd213383008435f35112d92
>
> Diff: https://reviews.apache.org/r/56569/diff/
>
>
> Testing
> -------
>
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>