You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/02/27 22:11:15 UTC
Review Request 57106: Added `FrameworkInfo` to
`UpdateFrameworkMessage`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57106/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6627
https://issues.apache.org/jira/browse/MESOS-6627
Repository: mesos
Description
-------
Taken verbatim from the [design doc](https://docs.google.com/document/d/1n0ZtRL49m3qpAeB4beEEhjTXQS-nYAbgRG9g44fn4WY).
Diffs
-----
src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698
Diff: https://reviews.apache.org/r/57106/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 57106: Added `FrameworkInfo` to
`UpdateFrameworkMessage`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57106/#review166990
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 27, 2017, 10:11 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57106/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 10:11 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6627
> https://issues.apache.org/jira/browse/MESOS-6627
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Taken verbatim from the [design doc](https://docs.google.com/document/d/1n0ZtRL49m3qpAeB4beEEhjTXQS-nYAbgRG9g44fn4WY).
>
>
> Diffs
> -----
>
> src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698
>
> Diff: https://reviews.apache.org/r/57106/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 57106: Added `FrameworkInfo` to
`UpdateFrameworkMessage`.
Posted by Michael Park <mp...@apache.org>.
> On Feb. 27, 2017, 6:42 p.m., Benjamin Mahler wrote:
> > src/messages/messages.proto
> > Lines 574-575 (patched)
> > <https://reviews.apache.org/r/57106/diff/1/?file=1650757#file1650757line574>
> >
> > Just one thing, looking at the subsequent patch, it appears that the agent updates the entire framework info, not just capabilities. So let's remove this TODO? Is there anything you want to call out here that won't be updated correctly by the agent if it were to change?
Oh, you're right. No, I don't think I have anything to call out here.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57106/#review166992
-----------------------------------------------------------
On Feb. 27, 2017, 2:11 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57106/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 2:11 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6627
> https://issues.apache.org/jira/browse/MESOS-6627
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Taken verbatim from the [design doc](https://docs.google.com/document/d/1n0ZtRL49m3qpAeB4beEEhjTXQS-nYAbgRG9g44fn4WY).
>
>
> Diffs
> -----
>
> src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698
>
>
> Diff: https://reviews.apache.org/r/57106/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 57106: Added `FrameworkInfo` to
`UpdateFrameworkMessage`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57106/#review166992
-----------------------------------------------------------
src/messages/messages.proto (lines 574 - 575)
<https://reviews.apache.org/r/57106/#comment239096>
Just one thing, looking at the subsequent patch, it appears that the agent updates the entire framework info, not just capabilities. So let's remove this TODO? Is there anything you want to call out here that won't be updated correctly by the agent if it were to change?
- Benjamin Mahler
On Feb. 27, 2017, 10:11 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57106/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 10:11 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6627
> https://issues.apache.org/jira/browse/MESOS-6627
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Taken verbatim from the [design doc](https://docs.google.com/document/d/1n0ZtRL49m3qpAeB4beEEhjTXQS-nYAbgRG9g44fn4WY).
>
>
> Diffs
> -----
>
> src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698
>
> Diff: https://reviews.apache.org/r/57106/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 57106: Added `FrameworkInfo` to
`UpdateFrameworkMessage`.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57106/#review167655
-----------------------------------------------------------
Ship it!
Ship It!
- Jay Guo
On Feb. 28, 2017, 6:11 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57106/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 6:11 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6627
> https://issues.apache.org/jira/browse/MESOS-6627
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Taken verbatim from the [design doc](https://docs.google.com/document/d/1n0ZtRL49m3qpAeB4beEEhjTXQS-nYAbgRG9g44fn4WY).
>
>
> Diffs
> -----
>
> src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698
>
>
> Diff: https://reviews.apache.org/r/57106/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 57106: Added `FrameworkInfo` to
`UpdateFrameworkMessage`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57106/#review166971
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57104, 57105, 57106]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 27, 2017, 10:11 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57106/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2017, 10:11 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6627
> https://issues.apache.org/jira/browse/MESOS-6627
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Taken verbatim from the [design doc](https://docs.google.com/document/d/1n0ZtRL49m3qpAeB4beEEhjTXQS-nYAbgRG9g44fn4WY).
>
>
> Diffs
> -----
>
> src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698
>
> Diff: https://reviews.apache.org/r/57106/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 57106: Added `FrameworkInfo` to
`UpdateFrameworkMessage`.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57106/
-----------------------------------------------------------
(Updated March 2, 2017, 1:45 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6627
https://issues.apache.org/jira/browse/MESOS-6627
Repository: mesos
Description (updated)
-------
Added `FrameworkInfo` to `UpdateFrameworkMessage`.
Diffs (updated)
-----
src/messages/messages.proto 2da89a8e6893b6be1faa89a6e1011f80fe643698
Diff: https://reviews.apache.org/r/57106/diff/2/
Changes: https://reviews.apache.org/r/57106/diff/1-2/
Testing
-------
Thanks,
Michael Park