You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/02/16 14:11:51 UTC

Review Request 56754: Implemented a JWT secret generator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56754/
-----------------------------------------------------------

Review request for mesos and Greg Mann.


Bugs: MESOS-7000
    https://issues.apache.org/jira/browse/MESOS-7000


Repository: mesos


Description
-------

This can be used to create a 'Secret' from an 'AuthenticationContext'.
The resulting secret will provide a JWT.


Diffs
-----

  src/Makefile.am c21a073bdbefbb4547e45ed13b7a8a563854fd82 
  src/authentication/executor/secret_generator.hpp PRE-CREATION 
  src/authentication/executor/secret_generator.cpp PRE-CREATION 
  src/tests/secret_generator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/56754/diff/


Testing
-------

make check


Thanks,

Jan Schlicht

Re: Review Request 56754: Implemented a JWT secret generator.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56754/#review166381
-----------------------------------------------------------



Patch looks great!

Reviews applied: [56623, 56617, 56618, 56901, 56619, 56812, 56813, 56624, 56621, 56665, 56666, 56667, 56757, 56754]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 22, 2017, 2:29 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56754/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2017, 2:29 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-7000
>     https://issues.apache.org/jira/browse/MESOS-7000
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This can be used to create a 'Secret' from an 'AuthenticationContext'.
> The resulting secret will provide a JWT.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 89fc72b8b4757f6b7a2f090167cca49ff46cff52 
>   src/authentication/executor/jwt_secret_generator.hpp PRE-CREATION 
>   src/authentication/executor/jwt_secret_generator.cpp PRE-CREATION 
>   src/tests/secret_generator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56754/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 56754: Implemented a JWT secret generator.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56754/
-----------------------------------------------------------

(Updated Feb. 22, 2017, 3:29 p.m.)


Review request for mesos and Greg Mann.


Changes
-------

Rebased.


Bugs: MESOS-7000
    https://issues.apache.org/jira/browse/MESOS-7000


Repository: mesos


Description
-------

This can be used to create a 'Secret' from an 'AuthenticationContext'.
The resulting secret will provide a JWT.


Diffs (updated)
-----

  src/Makefile.am 89fc72b8b4757f6b7a2f090167cca49ff46cff52 
  src/authentication/executor/jwt_secret_generator.hpp PRE-CREATION 
  src/authentication/executor/jwt_secret_generator.cpp PRE-CREATION 
  src/tests/secret_generator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/56754/diff/


Testing
-------

make check


Thanks,

Jan Schlicht

Re: Review Request 56754: Implemented a JWT secret generator.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56754/
-----------------------------------------------------------

(Updated Feb. 16, 2017, 3:55 p.m.)


Review request for mesos and Greg Mann.


Changes
-------

Extract the SecretGenerator interface/module.


Bugs: MESOS-7000
    https://issues.apache.org/jira/browse/MESOS-7000


Repository: mesos


Description
-------

This can be used to create a 'Secret' from an 'AuthenticationContext'.
The resulting secret will provide a JWT.


Diffs (updated)
-----

  src/Makefile.am c21a073bdbefbb4547e45ed13b7a8a563854fd82 
  src/authentication/executor/jwt_secret_generator.hpp PRE-CREATION 
  src/authentication/executor/jwt_secret_generator.cpp PRE-CREATION 
  src/tests/secret_generator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/56754/diff/


Testing
-------

make check


Thanks,

Jan Schlicht