You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/07 02:31:21 UTC
Review Request 56366: Windows: Refactor executor to use `SharedHandle`
semantics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56366/
-----------------------------------------------------------
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-6892
https://issues.apache.org/jira/browse/MESOS-6892
Repository: mesos
Description
-------
The executor now owns the `SharedHandle` for the process and job object,
so that their lifetime is correctly tied to the executor and their
handles will be closed properly.
Diffs
-----
src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
src/launcher/windows/executor.hpp 6f02912c477105819b4c27ddf248b7289799eaa0
src/launcher/windows/executor.cpp b51fde7376c2083119f342ea599b446944ede000
Diff: https://reviews.apache.org/r/56366/diff/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 56366: Windows: Refactor executor to use
`SharedHandle` semantics.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56366/#review165030
-----------------------------------------------------------
src/launcher/windows/executor.cpp (lines 105 - 119)
<https://reviews.apache.org/r/56366/#comment236870>
Hm. The code duplication between here and the WindowsLauncher makes me think that we should move JobObject creation/management to a libprocess actor of some sort.
It would be logically similar to the WindowsLauncher, but have a lifecycle like the `ReaperProcess`. It would also need to be Windows-only.
- Joseph Wu
On Feb. 8, 2017, 1:16 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56366/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 1:16 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-6892
> https://issues.apache.org/jira/browse/MESOS-6892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The executor now owns the `SharedHandle` for the process and job object,
> so that their lifetime is correctly tied to the executor and their
> handles will be closed properly.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
> src/launcher/windows/executor.hpp 6f02912c477105819b4c27ddf248b7289799eaa0
> src/launcher/windows/executor.cpp b51fde7376c2083119f342ea599b446944ede000
>
> Diff: https://reviews.apache.org/r/56366/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56366: Windows: Refactor executor to use
`SharedHandle` semantics.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56366/
-----------------------------------------------------------
(Updated March 27, 2017, 3:43 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-6892
https://issues.apache.org/jira/browse/MESOS-6892
Repository: mesos
Description
-------
The executor now owns the `SharedHandle` for the process and job object,
so that their lifetime is correctly tied to the executor and their
handles will be closed properly.
Diffs
-----
src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
src/launcher/windows/executor.hpp 6f02912c477105819b4c27ddf248b7289799eaa0
src/launcher/windows/executor.cpp b51fde7376c2083119f342ea599b446944ede000
Diff: https://reviews.apache.org/r/56366/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 56366: Windows: Refactor executor to use
`SharedHandle` semantics.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56366/#review164828
-----------------------------------------------------------
Bad patch!
Reviews applied: [56366, 56364, 56363]
Failed command: python support/apply-reviews.py -n -r 56366
Error:
2017-02-09 02:37:50 URL:https://reviews.apache.org/r/56366/diff/raw/ [5273/5273] -> "56366.patch" [1]
error: patch failed: src/launcher/executor.cpp:140
error: src/launcher/executor.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17030/console
- Mesos Reviewbot
On Feb. 8, 2017, 9:16 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56366/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 9:16 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-6892
> https://issues.apache.org/jira/browse/MESOS-6892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The executor now owns the `SharedHandle` for the process and job object,
> so that their lifetime is correctly tied to the executor and their
> handles will be closed properly.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
> src/launcher/windows/executor.hpp 6f02912c477105819b4c27ddf248b7289799eaa0
> src/launcher/windows/executor.cpp b51fde7376c2083119f342ea599b446944ede000
>
> Diff: https://reviews.apache.org/r/56366/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56366: Windows: Refactor executor to use
`SharedHandle` semantics.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56366/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 9:16 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Changes
-------
Fix the patch dependency.
Bugs: MESOS-6892
https://issues.apache.org/jira/browse/MESOS-6892
Repository: mesos
Description
-------
The executor now owns the `SharedHandle` for the process and job object,
so that their lifetime is correctly tied to the executor and their
handles will be closed properly.
Diffs
-----
src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
src/launcher/windows/executor.hpp 6f02912c477105819b4c27ddf248b7289799eaa0
src/launcher/windows/executor.cpp b51fde7376c2083119f342ea599b446944ede000
Diff: https://reviews.apache.org/r/56366/diff/
Testing
-------
Thanks,
Andrew Schwartzmeyer