You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/02/24 08:51:09 UTC
Review Request 57023: Added a test to ensure agent could be upgrade to
MULTI_ROLE capable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57023/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
Bugs: MESOS-7165
https://issues.apache.org/jira/browse/MESOS-7165
Repository: mesos
Description
-------
Added a test to ensure agent could be upgrade to MULTI_ROLE capable.
Diffs
-----
src/tests/upgrade_tests.cpp 32e241c2c7c39123a9767457f8525abbbe8816c7
Diff: https://reviews.apache.org/r/57023/diff/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 57023: Added a test to ensure agent could be
upgrade to MULTI_ROLE capable.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57023/#review166965
-----------------------------------------------------------
Ship it!
src/tests/upgrade_tests.cpp (line 268)
<https://reviews.apache.org/r/57023/#comment239063>
We should call this something multi role specific.
- Benjamin Mahler
On Feb. 24, 2017, 8:51 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57023/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 8:51 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
>
>
> Bugs: MESOS-7165
> https://issues.apache.org/jira/browse/MESOS-7165
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to ensure agent could be upgrade to MULTI_ROLE capable.
>
>
> Diffs
> -----
>
> src/tests/upgrade_tests.cpp 32e241c2c7c39123a9767457f8525abbbe8816c7
>
> Diff: https://reviews.apache.org/r/57023/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 57023: Added a test to ensure agent could be
upgrade to MULTI_ROLE capable.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57023/#review166670
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56967, 56837, 56530, 57021, 57023]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 24, 2017, 8:51 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57023/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 8:51 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
>
>
> Bugs: MESOS-7165
> https://issues.apache.org/jira/browse/MESOS-7165
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to ensure agent could be upgrade to MULTI_ROLE capable.
>
>
> Diffs
> -----
>
> src/tests/upgrade_tests.cpp 32e241c2c7c39123a9767457f8525abbbe8816c7
>
> Diff: https://reviews.apache.org/r/57023/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>