You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/01 21:26:58 UTC
Review Request 56188: Removed all instances of '.Times(1)' from
libprocess tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56188/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Using `.Times(1)` with `EXPECT_CALL` is redundant, as this
is implied by default. This patch removes all such remaining
occurrences from the libprocess tests.
Diffs
-----
3rdparty/libprocess/src/tests/process_tests.cpp cd159b6dbde44d89bca76c6ec99cc22621638b2a
Diff: https://reviews.apache.org/r/56188/diff/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 56188: Removed all instances of '.Times(1)' from
libprocess tests.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56188/#review163892
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 1, 2017, 9:26 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56188/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 9:26 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Using `.Times(1)` with `EXPECT_CALL` is redundant, as this
> is implied by default. This patch removes all such remaining
> occurrences from the libprocess tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/process_tests.cpp cd159b6dbde44d89bca76c6ec99cc22621638b2a
>
> Diff: https://reviews.apache.org/r/56188/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56188: Removed all instances of '.Times(1)' from
libprocess tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56188/#review163896
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55954, 55955, 56055, 56052, 56053, 56139, 56187, 56188]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 1, 2017, 9:26 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56188/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 9:26 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Using `.Times(1)` with `EXPECT_CALL` is redundant, as this
> is implied by default. This patch removes all such remaining
> occurrences from the libprocess tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/process_tests.cpp cd159b6dbde44d89bca76c6ec99cc22621638b2a
>
> Diff: https://reviews.apache.org/r/56188/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56188: Removed all instances of '.Times(1)' from
libprocess tests.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56188/#review163953
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Feb. 1, 2017, 10:26 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56188/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 10:26 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Using `.Times(1)` with `EXPECT_CALL` is redundant, as this
> is implied by default. This patch removes all such remaining
> occurrences from the libprocess tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/process_tests.cpp cd159b6dbde44d89bca76c6ec99cc22621638b2a
>
> Diff: https://reviews.apache.org/r/56188/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>