You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/02/24 10:52:47 UTC
Review Request 57030: Added allocation role validation for TaskInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57030/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6636
https://issues.apache.org/jira/browse/MESOS-6636
Repository: mesos
Description
-------
With support for multi-role frameworks, we need to make sure that
individual task cannot mix allocation roles.
Diffs
-----
src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31
Diff: https://reviews.apache.org/r/57030/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 57030: Added allocation role validation for
TaskInfo.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57030/#review166764
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_validation_tests.cpp (lines 1835 - 1836)
<https://reviews.apache.org/r/57030/#comment238840>
We should test the case where the task has unallocated resources as well, per my suggestion on the previous review.
- Benjamin Mahler
On Feb. 24, 2017, 10:52 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57030/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 10:52 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6636
> https://issues.apache.org/jira/browse/MESOS-6636
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With support for multi-role frameworks, we need to make sure that
> individual task cannot mix allocation roles.
>
>
> Diffs
> -----
>
> src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f
> src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31
>
> Diff: https://reviews.apache.org/r/57030/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>