You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/02/02 09:57:58 UTC
Review Request 56214: Hashed unacknowledged updates by UUID string in
default executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56214/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
Diff: https://reviews.apache.org/r/56214/diff/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 56214: Hashed unacknowledged updates by UUID
string in default executor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56214/#review165771
-----------------------------------------------------------
See my comments in the previous review. Don't think we should do this.
- Vinod Kone
On Feb. 8, 2017, 4:57 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56214/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 4:57 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6906
> https://issues.apache.org/jira/browse/MESOS-6906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update acknowledgements contain UUID as string, a conversion is
> anyway necessary. In the future we may not have access to the
> original UUID, while string representation is always available in
> the protobuf message itself. Hence it seems reasonable to hash
> updates by string instead of UUID.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a
>
> Diff: https://reviews.apache.org/r/56214/diff/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/56218/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 56214: Hashed unacknowledged updates by UUID
string in default executor.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56214/
-----------------------------------------------------------
(Updated March 16, 2017, 11:18 a.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
Update acknowledgements contain UUID as string, a conversion is
anyway necessary. In the future we may not have access to the
original UUID, while string representation is always available in
the protobuf message itself. Hence it seems reasonable to hash
updates by string instead of UUID.
Diffs
-----
src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a
Diff: https://reviews.apache.org/r/56214/diff/3/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 56214: Hashed unacknowledged updates by UUID
string in default executor.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56214/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 4:57 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description
-------
Update acknowledgements contain UUID as string, a conversion is
anyway necessary. In the future we may not have access to the
original UUID, while string representation is always available in
the protobuf message itself. Hence it seems reasonable to hash
updates by string instead of UUID.
Diffs (updated)
-----
src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a
Diff: https://reviews.apache.org/r/56214/diff/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 56214: Hashed unacknowledged updates by UUID
string in default executor.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56214/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 3:20 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Bugs: MESOS-6906
https://issues.apache.org/jira/browse/MESOS-6906
Repository: mesos
Description (updated)
-------
Update acknowledgements contain UUID as string, a conversion is
anyway necessary. In the future we may not have access to the
original UUID, while string representation is always available in
the protobuf message itself. Hence it seems reasonable to hash
updates by string instead of UUID.
Diffs (updated)
-----
src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a
Diff: https://reviews.apache.org/r/56214/diff/
Testing
-------
See https://reviews.apache.org/r/56218/
Thanks,
Alexander Rukletsov
Re: Review Request 56214: Hashed unacknowledged updates by UUID
string in default executor.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56214/#review164322
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Feb. 2, 2017, 9:57 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56214/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 9:57 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-6906
> https://issues.apache.org/jira/browse/MESOS-6906
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
>
> Diff: https://reviews.apache.org/r/56214/diff/
>
>
> Testing
> -------
>
> See https://reviews.apache.org/r/56218/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>