You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.com> on 2017/02/02 16:54:53 UTC

Re: Review Request 55900: Improved style in `HealthChecker`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55900/
-----------------------------------------------------------

(Updated Feb. 2, 2017, 4:54 p.m.)


Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.


Changes
-------

Rebased.


Bugs: MESOS-6280
    https://issues.apache.org/jira/browse/MESOS-6280


Repository: mesos


Description
-------

Marked `_taskPid` in the constructor as const, to be consistent with the
other parameters.


Diffs (updated)
-----

  src/checks/health_checker.hpp 95da1ff7dd6b222a93076633eb3757ec9aa43cf6 
  src/checks/health_checker.cpp 58380dc18896f659aa9c4fb4bb567a55bba97f6b 

Diff: https://reviews.apache.org/r/55900/diff/


Testing
-------

`make check` (macOS and Linux)


Thanks,

Gast�n Kleiman

Re: Review Request 55900: Improved style in `HealthChecker`.

Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55900/#review164311
-----------------------------------------------------------


Ship it!




Ship It!

- haosdent huang


On Feb. 2, 2017, 4:54 p.m., Gast�n Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55900/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 4:54 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-6280
>     https://issues.apache.org/jira/browse/MESOS-6280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Marked `_taskPid` in the constructor as const, to be consistent with the
> other parameters.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.hpp 95da1ff7dd6b222a93076633eb3757ec9aa43cf6 
>   src/checks/health_checker.cpp 58380dc18896f659aa9c4fb4bb567a55bba97f6b 
> 
> Diff: https://reviews.apache.org/r/55900/diff/
> 
> 
> Testing
> -------
> 
> `make check` (macOS and Linux)
> 
> 
> Thanks,
> 
> Gast�n Kleiman
> 
>