You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/02/13 10:34:26 UTC
Review Request 56594: Explicitly marked protobuf files as using v2
syntax.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56594/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Repository: mesos
Description
-------
`protoc` will complain about `.proto` files that do not explicitly
specify the version of PB syntax they're using. On Windows, this
registers as a build warning.
To ameliorate this, we explicitly specify the syntax in all `.proto`
files.
Diffs
-----
3rdparty/stout/tests/protobuf_tests.proto 229ac256b087d55ecc95636254261ecd12829187
Diff: https://reviews.apache.org/r/56594/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 56594: Explicitly marked protobuf files as using v2
syntax.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56594/#review165325
-----------------------------------------------------------
Bad patch!
Reviews applied: [56594, 56593, 56592, 56591, 56505, 56504, 55749, 55550, 55549, 55547, 55546, 55543, 55162, 55030, 55024, 55023, 55022]
Failed command: python support/apply-reviews.py -n -r 55030
Error:
2017-02-13 14:11:55 URL:https://reviews.apache.org/r/55030/diff/raw/ [3711/3711] -> "55030.patch" [1]
error: patch failed: 3rdparty/libprocess/src/tests/CMakeLists.txt:16
error: 3rdparty/libprocess/src/tests/CMakeLists.txt: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/17069/console
- Mesos Reviewbot
On Feb. 13, 2017, 10:34 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56594/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 10:34 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `protoc` will complain about `.proto` files that do not explicitly
> specify the version of PB syntax they're using. On Windows, this
> registers as a build warning.
>
> To ameliorate this, we explicitly specify the syntax in all `.proto`
> files.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.proto 229ac256b087d55ecc95636254261ecd12829187
>
> Diff: https://reviews.apache.org/r/56594/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 56594: Explicitly marked protobuf files as using v2
syntax.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56594/#review165893
-----------------------------------------------------------
Ship it!
Effectively the same as: https://reviews.apache.org/r/56237/
So I'll close both and attribute the patch to Anthony.
- Joseph Wu
On Feb. 16, 2017, 2:58 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56594/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 2:58 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-6138
> https://issues.apache.org/jira/browse/MESOS-6138
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `protoc` will complain about `.proto` files that do not explicitly
> specify the version of PB syntax they're using. On Windows, this
> registers as a build warning.
>
> To ameliorate this, we explicitly specify the syntax in all `.proto`
> files.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/protobuf_tests.proto 229ac256b087d55ecc95636254261ecd12829187
>
> Diff: https://reviews.apache.org/r/56594/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 56594: Explicitly marked protobuf files as using v2
syntax.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56594/
-----------------------------------------------------------
(Updated Feb. 16, 2017, 2:58 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Changes
-------
Added JIRA -- Joseph Wu.
Bugs: MESOS-6138
https://issues.apache.org/jira/browse/MESOS-6138
Repository: mesos
Description
-------
`protoc` will complain about `.proto` files that do not explicitly
specify the version of PB syntax they're using. On Windows, this
registers as a build warning.
To ameliorate this, we explicitly specify the syntax in all `.proto`
files.
Diffs
-----
3rdparty/stout/tests/protobuf_tests.proto 229ac256b087d55ecc95636254261ecd12829187
Diff: https://reviews.apache.org/r/56594/diff/
Testing
-------
Thanks,
Alex Clemmer