You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anthony Sottile <as...@yelp.com> on 2017/02/02 20:13:00 UTC
Review Request 56238: Allow a newer version of google protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56238/
-----------------------------------------------------------
Review request for mesos, Deshi Xiao, Yong Tang, and Zhitao Li.
Bugs: MESOS-5186 and MESOS-6138
https://issues.apache.org/jira/browse/MESOS-5186
https://issues.apache.org/jira/browse/MESOS-6138
Repository: mesos
Description
-------
Allow a newer version of google protobuf.
Diffs
-----
src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa
src/python/protocol/setup.py.in 5dd4a0a0f67c4003b58319d0d6c7bb227e8a13a1
Diff: https://reviews.apache.org/r/56238/diff/
Testing
-------
Thanks,
Anthony Sottile
Re: Review Request 56238: Allow a newer version of google protobuf.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56238/#review164061
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56236, 56237, 56238]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 2, 2017, 8:13 p.m., Anthony Sottile wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56238/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 8:13 p.m.)
>
>
> Review request for mesos, Deshi Xiao, Yong Tang, and Zhitao Li.
>
>
> Bugs: MESOS-5186 and MESOS-6138
> https://issues.apache.org/jira/browse/MESOS-5186
> https://issues.apache.org/jira/browse/MESOS-6138
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow a newer version of google protobuf.
>
>
> Diffs
> -----
>
> src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa
> src/python/protocol/setup.py.in 5dd4a0a0f67c4003b58319d0d6c7bb227e8a13a1
>
> Diff: https://reviews.apache.org/r/56238/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Sottile
>
>
Re: Review Request 56238: Allowed using protobuf 3 in python bindings.
Posted by haosdent huang <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56238/#review166018
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Feb. 18, 2017, 2:23 a.m., Anthony Sottile wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56238/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2017, 2:23 a.m.)
>
>
> Review request for mesos, Deshi Xiao, Yong Tang, and Zhitao Li.
>
>
> Bugs: MESOS-5186 and MESOS-6138
> https://issues.apache.org/jira/browse/MESOS-5186
> https://issues.apache.org/jira/browse/MESOS-6138
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allowed using protobuf 3 in python bindings.
>
>
> Diffs
> -----
>
> src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa
> src/python/protocol/setup.py.in 5dd4a0a0f67c4003b58319d0d6c7bb227e8a13a1
>
> Diff: https://reviews.apache.org/r/56238/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Anthony Sottile
>
>
Re: Review Request 56238: Allowed using protobuf 3 in python bindings.
Posted by Anthony Sottile <as...@yelp.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56238/
-----------------------------------------------------------
(Updated Feb. 18, 2017, 2:23 a.m.)
Review request for mesos, Deshi Xiao, Yong Tang, and Zhitao Li.
Bugs: MESOS-5186 and MESOS-6138
https://issues.apache.org/jira/browse/MESOS-5186
https://issues.apache.org/jira/browse/MESOS-6138
Repository: mesos
Description (updated)
-------
Allowed using protobuf 3 in python bindings.
Diffs
-----
src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa
src/python/protocol/setup.py.in 5dd4a0a0f67c4003b58319d0d6c7bb227e8a13a1
Diff: https://reviews.apache.org/r/56238/diff/
Testing
-------
Thanks,
Anthony Sottile
Re: Review Request 56238: Allowed using protobuf 3 in python bindings.
Posted by Anthony Sottile <as...@yelp.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56238/
-----------------------------------------------------------
(Updated Feb. 18, 2017, 2:23 a.m.)
Review request for mesos, Deshi Xiao, Yong Tang, and Zhitao Li.
Summary (updated)
-----------------
Allowed using protobuf 3 in python bindings.
Bugs: MESOS-5186 and MESOS-6138
https://issues.apache.org/jira/browse/MESOS-5186
https://issues.apache.org/jira/browse/MESOS-6138
Repository: mesos
Description
-------
Allow a newer version of google protobuf.
Diffs
-----
src/python/interface/setup.py.in 037c2ec8e63f497f7029a847a7a0d7b72e6f36fa
src/python/protocol/setup.py.in 5dd4a0a0f67c4003b58319d0d6c7bb227e8a13a1
Diff: https://reviews.apache.org/r/56238/diff/
Testing
-------
Thanks,
Anthony Sottile