You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/02/07 22:13:00 UTC
Review Request 56408: Fixed a regression in the execute CLI command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56408/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Gast�n Kleiman.
Bugs: MESOS-7075
https://issues.apache.org/jira/browse/MESOS-7075
Repository: mesos
Description
-------
With the addition of `Resource.allocation_info` to support MULTI_ROLE
frameworks, the execute helper has pulled in the updated `Resources`
library and needs to be updated to be aware of allocation info.
Diffs
-----
src/cli/execute.cpp 50969145ae02f90d324078d94a8ab09d2191cce0
Diff: https://reviews.apache.org/r/56408/diff/
Testing
-------
Manually tested against a new master.
Thanks,
Benjamin Mahler
Re: Review Request 56408: Fixed a regression in the execute CLI
command.
Posted by Gastón Kleiman <ga...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56408/#review164572
-----------------------------------------------------------
Ship it!
Ship It!
- Gast�n Kleiman
On Feb. 7, 2017, 10:28 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56408/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:28 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gast�n Kleiman.
>
>
> Bugs: MESOS-7075
> https://issues.apache.org/jira/browse/MESOS-7075
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the addition of `Resource.allocation_info` to support MULTI_ROLE
> frameworks, the execute helper has pulled in the updated `Resources`
> library and needs to be updated to be aware of allocation info.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp 50969145ae02f90d324078d94a8ab09d2191cce0
>
> Diff: https://reviews.apache.org/r/56408/diff/
>
>
> Testing
> -------
>
> Manually tested against a new master.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 56408: Fixed a regression in the execute CLI
command.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56408/#review164573
-----------------------------------------------------------
Ship it!
Can you update the review description/testing done accordingly after the recent update?
- Anand Mazumdar
On Feb. 7, 2017, 10:28 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56408/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:28 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Gast�n Kleiman.
>
>
> Bugs: MESOS-7075
> https://issues.apache.org/jira/browse/MESOS-7075
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the addition of `Resource.allocation_info` to support MULTI_ROLE
> frameworks, the execute helper has pulled in the updated `Resources`
> library and needs to be updated to be aware of allocation info.
>
>
> Diffs
> -----
>
> src/cli/execute.cpp 50969145ae02f90d324078d94a8ab09d2191cce0
>
> Diff: https://reviews.apache.org/r/56408/diff/
>
>
> Testing
> -------
>
> Manually tested against a new master.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 56408: Fixed a regression in the execute CLI
command.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56408/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 10:28 p.m.)
Review request for mesos, Anand Mazumdar and Gast�n Kleiman.
Changes
-------
Updated to work against both old and new masters.
Bugs: MESOS-7075
https://issues.apache.org/jira/browse/MESOS-7075
Repository: mesos
Description
-------
With the addition of `Resource.allocation_info` to support MULTI_ROLE
frameworks, the execute helper has pulled in the updated `Resources`
library and needs to be updated to be aware of allocation info.
Diffs (updated)
-----
src/cli/execute.cpp 50969145ae02f90d324078d94a8ab09d2191cce0
Diff: https://reviews.apache.org/r/56408/diff/
Testing
-------
Manually tested against a new master.
Thanks,
Benjamin Mahler