You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/02/28 17:25:06 UTC
Review Request 57132: Updated WebUI to display roles.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57132/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-6657
https://issues.apache.org/jira/browse/MESOS-6657
Repository: mesos
Description
-------
With support of multi-tenancy in Mesos, WebUI needs to be updated
to correctly display role information.
Diffs
-----
src/webui/master/static/agent.html 7a4599367ea8ff802591adfd86d4058cdc51f297
src/webui/master/static/agent_executor.html 95e921d1c3ca0f005e3eb3f79eb0d9a70a3b3f91
src/webui/master/static/agent_framework.html 806ab06063dcf62cd6d1d7913840ed83141bd1eb
src/webui/master/static/framework.html 37e0b31ac90e877b70f315143b7411fadeeeeec6
src/webui/master/static/frameworks.html 0c6fc1c37e0ab49fed64aaa861dfcbaab7f38e0e
src/webui/master/static/js/controllers.js 2ea8275cb5fffa2344474ebfcf9277fe92165a92
src/webui/master/static/offers.html 181fc2deabef3faec36785e7fcdbc37465668bec
Diff: https://reviews.apache.org/r/57132/diff/
Testing
-------
manually test by launching new master with both new/old agent, and inspect WebUI to see roles.
Thanks,
Jay Guo
Re: Review Request 57132: Fixed WebUI data-key.
Posted by Benjamin Mahler <bm...@apache.org>.
> On March 1, 2017, 6:55 p.m., Benjamin Mahler wrote:
> > There are probably other `data-key`s that are broken too, I didn't do a sweep when I had suggested fixing these :)
By the way, you can test if the data-key is correct by clicking the table headers and seeing if it sorts in ascending vs descending order.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57132/#review167541
-----------------------------------------------------------
On March 1, 2017, 10:23 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57132/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 10:23 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6657
> https://issues.apache.org/jira/browse/MESOS-6657
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some of the data-key are incorrect, which causes sorting problem.
>
>
> Diffs
> -----
>
> src/webui/master/static/agent.html 7a4599367ea8ff802591adfd86d4058cdc51f297
>
>
> Diff: https://reviews.apache.org/r/57132/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 57132: Fixed WebUI data-key.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57132/#review167541
-----------------------------------------------------------
Ship it!
There are probably other `data-key`s that are broken too, I didn't do a sweep when I had suggested fixing these :)
- Benjamin Mahler
On March 1, 2017, 10:23 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57132/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 10:23 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6657
> https://issues.apache.org/jira/browse/MESOS-6657
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some of the data-key are incorrect, which causes sorting problem.
>
>
> Diffs
> -----
>
> src/webui/master/static/agent.html 7a4599367ea8ff802591adfd86d4058cdc51f297
>
>
> Diff: https://reviews.apache.org/r/57132/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 57132: Fixed WebUI data-key.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57132/
-----------------------------------------------------------
(Updated March 1, 2017, 6:23 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
split into several patches.
Summary (updated)
-----------------
Fixed WebUI data-key.
Bugs: MESOS-6657
https://issues.apache.org/jira/browse/MESOS-6657
Repository: mesos
Description (updated)
-------
Some of the data-key are incorrect, which causes sorting problem.
Diffs (updated)
-----
src/webui/master/static/agent.html 7a4599367ea8ff802591adfd86d4058cdc51f297
Diff: https://reviews.apache.org/r/57132/diff/2/
Changes: https://reviews.apache.org/r/57132/diff/1-2/
Testing (updated)
-------
Thanks,
Jay Guo
Re: Review Request 57132: Updated WebUI to display roles.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57132/#review167165
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57013, 57132]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 28, 2017, 5:25 p.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57132/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 5:25 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-6657
> https://issues.apache.org/jira/browse/MESOS-6657
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With support of multi-tenancy in Mesos, WebUI needs to be updated
> to correctly display role information.
>
>
> Diffs
> -----
>
> src/webui/master/static/agent.html 7a4599367ea8ff802591adfd86d4058cdc51f297
> src/webui/master/static/agent_executor.html 95e921d1c3ca0f005e3eb3f79eb0d9a70a3b3f91
> src/webui/master/static/agent_framework.html 806ab06063dcf62cd6d1d7913840ed83141bd1eb
> src/webui/master/static/framework.html 37e0b31ac90e877b70f315143b7411fadeeeeec6
> src/webui/master/static/frameworks.html 0c6fc1c37e0ab49fed64aaa861dfcbaab7f38e0e
> src/webui/master/static/js/controllers.js 2ea8275cb5fffa2344474ebfcf9277fe92165a92
> src/webui/master/static/offers.html 181fc2deabef3faec36785e7fcdbc37465668bec
>
> Diff: https://reviews.apache.org/r/57132/diff/
>
>
> Testing
> -------
>
> manually test by launching new master with both new/old agent, and inspect WebUI to see roles.
>
>
> Thanks,
>
> Jay Guo
>
>