You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/02/22 19:17:05 UTC
Re: Review Request 56809: Added test for nested container agent
reboot case.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 11:17 a.m.)
Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
Summary (updated)
-----------------
Added test for nested container agent reboot case.
Bugs: MESOS-7152
https://issues.apache.org/jira/browse/MESOS-7152
Repository: mesos
Description (updated)
-------
Added test for nested container agent reboot case.
Diffs (updated)
-----
src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c
Diff: https://reviews.apache.org/r/56809/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56809: Added test for nested container agent
reboot case.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/#review166407
-----------------------------------------------------------
src/tests/containerizer/nested_mesos_containerizer_tests.cpp (lines 988 - 1000)
<https://reviews.apache.org/r/56809/#comment238329>
Why you need to create the containerizer here?
src/tests/containerizer/nested_mesos_containerizer_tests.cpp (line 1015)
<https://reviews.apache.org/r/56809/#comment238330>
Can you just call provisioner->recover()?
- Jie Yu
On Feb. 22, 2017, 7:17 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56809/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 7:17 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7152
> https://issues.apache.org/jira/browse/MESOS-7152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for nested container agent reboot case.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c
>
> Diff: https://reviews.apache.org/r/56809/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56809: Added test for nested container agent
reboot case.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 6:33 p.m.)
Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
Bugs: MESOS-7152
https://issues.apache.org/jira/browse/MESOS-7152
Repository: mesos
Description
-------
Added test for nested container agent reboot case.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp ce57c06d50b47a150ff40412c1fde99f16892434
Diff: https://reviews.apache.org/r/56809/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56809: Added test for nested container agent
reboot case.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/#review166459
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 23, 2017, 1:05 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56809/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 1:05 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7152
> https://issues.apache.org/jira/browse/MESOS-7152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for nested container agent reboot case.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp ce57c06d50b47a150ff40412c1fde99f16892434
>
> Diff: https://reviews.apache.org/r/56809/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56809: Added test for nested container agent
reboot case.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 5:05 p.m.)
Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
Bugs: MESOS-7152
https://issues.apache.org/jira/browse/MESOS-7152
Repository: mesos
Description
-------
Added test for nested container agent reboot case.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp ce57c06d50b47a150ff40412c1fde99f16892434
Diff: https://reviews.apache.org/r/56809/diff/
Testing
-------
make check
Thanks,
Gilbert Song