You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/02/28 15:51:15 UTC
Review Request 57149: Added a warning if command executor gets an
unknown acknowledgement.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57149/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/57149/diff/
Testing
-------
https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov
Re: Review Request 57149: Added a warning if command executor gets an
unknown acknowledgement.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57149/#review167769
-----------------------------------------------------------
Fix it, then Ship it!
src/launcher/executor.cpp
Lines 215 (patched)
<https://reviews.apache.org/r/57149/#comment239734>
log the UUID.
- Vinod Kone
On Feb. 28, 2017, 3:51 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57149/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 3:51 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
>
>
> Diff: https://reviews.apache.org/r/57149/diff/1/
>
>
> Testing
> -------
>
> https://reviews.apache.org/r/56213/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 57149: Added a warning if command executor gets an
unknown acknowledgement.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57149/#review168975
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 14, 2017, 2:06 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57149/
> -----------------------------------------------------------
>
> (Updated March 14, 2017, 2:06 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
>
>
> Diff: https://reviews.apache.org/r/57149/diff/3/
>
>
> Testing
> -------
>
> https://reviews.apache.org/r/56213/
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 57149: Added a warning if command executor gets an
unknown acknowledgement.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57149/
-----------------------------------------------------------
(Updated March 15, 2017, 12:46 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Changes
-------
Rebased. NNTR.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/57149/diff/4/
Changes: https://reviews.apache.org/r/57149/diff/3-4/
Testing
-------
https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov
Re: Review Request 57149: Added a warning if command executor gets an
unknown acknowledgement.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57149/
-----------------------------------------------------------
(Updated March 14, 2017, 2:06 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/57149/diff/3/
Changes: https://reviews.apache.org/r/57149/diff/2-3/
Testing
-------
https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov
Re: Review Request 57149: Added a warning if command executor gets an
unknown acknowledgement.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57149/
-----------------------------------------------------------
(Updated March 7, 2017, 8:39 p.m.)
Review request for mesos, Gast�n Kleiman and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378
Diff: https://reviews.apache.org/r/57149/diff/2/
Changes: https://reviews.apache.org/r/57149/diff/1-2/
Testing
-------
https://reviews.apache.org/r/56213/
Thanks,
Alexander Rukletsov