You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/07 02:31:03 UTC
Review Request 56363: Stout: Add predicate `find` semantics to
`hashmap`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56363/
-----------------------------------------------------------
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-6892
https://issues.apache.org/jira/browse/MESOS-6892
Repository: mesos
Description
-------
`Option<Value> hashmap::findIf(lambda::function<bool(Value)> predicate)`
filters `hashmap` values given a predicate (for more advanced kinds of
`Value`, say compare structs on a field).
`bool hashmap::containsIf(lambda::function<bool(Value)> predicate)`
checks whether a `Value` matching predicate exists in the `hashmap`
(just passes to `findIf` and acts like `hashmap::contains`).
Diffs
-----
3rdparty/stout/include/stout/hashmap.hpp 539bbfd9250f2f372c2b3211e2379ad2229fa35e
Diff: https://reviews.apache.org/r/56363/diff/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 56363: Stout: Add predicate `find` semantics to
`hashmap`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Feb. 23, 2017, 10:36 p.m., Joseph Wu wrote:
> > I know you really like this helper (:D), but since it is no longer used in any reviews/code, could you discard this patch?
Yeah. We'll resurrect it next time we need it :P
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56363/#review166597
-----------------------------------------------------------
On Feb. 8, 2017, 9:09 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56363/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 9:09 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-6892
> https://issues.apache.org/jira/browse/MESOS-6892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `Option<Value> hashmap::findIf(lambda::function<bool(Value)> predicate)`
> filters `hashmap` values given a predicate (for more advanced kinds of
> `Value`, say compare structs on a field).
>
> `bool hashmap::containsIf(lambda::function<bool(Value)> predicate)`
> checks whether a `Value` matching predicate exists in the `hashmap`
> (just passes to `findIf` and acts like `hashmap::contains`).
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/hashmap.hpp 539bbfd9250f2f372c2b3211e2379ad2229fa35e
>
> Diff: https://reviews.apache.org/r/56363/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56363: Stout: Add predicate `find` semantics to
`hashmap`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56363/#review166597
-----------------------------------------------------------
I know you really like this helper (:D), but since it is no longer used in any reviews/code, could you discard this patch?
- Joseph Wu
On Feb. 8, 2017, 1:09 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56363/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 1:09 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-6892
> https://issues.apache.org/jira/browse/MESOS-6892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `Option<Value> hashmap::findIf(lambda::function<bool(Value)> predicate)`
> filters `hashmap` values given a predicate (for more advanced kinds of
> `Value`, say compare structs on a field).
>
> `bool hashmap::containsIf(lambda::function<bool(Value)> predicate)`
> checks whether a `Value` matching predicate exists in the `hashmap`
> (just passes to `findIf` and acts like `hashmap::contains`).
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/hashmap.hpp 539bbfd9250f2f372c2b3211e2379ad2229fa35e
>
> Diff: https://reviews.apache.org/r/56363/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56363: Stout: Add predicate `find` semantics to
`hashmap`.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56363/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 9:09 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Changes
-------
Remove patch dependency (there is none).
Bugs: MESOS-6892
https://issues.apache.org/jira/browse/MESOS-6892
Repository: mesos
Description
-------
`Option<Value> hashmap::findIf(lambda::function<bool(Value)> predicate)`
filters `hashmap` values given a predicate (for more advanced kinds of
`Value`, say compare structs on a field).
`bool hashmap::containsIf(lambda::function<bool(Value)> predicate)`
checks whether a `Value` matching predicate exists in the `hashmap`
(just passes to `findIf` and acts like `hashmap::contains`).
Diffs
-----
3rdparty/stout/include/stout/hashmap.hpp 539bbfd9250f2f372c2b3211e2379ad2229fa35e
Diff: https://reviews.apache.org/r/56363/diff/
Testing
-------
Thanks,
Andrew Schwartzmeyer