You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/02/20 07:18:53 UTC
Re: Review Request 56644: Added a constant to store agent
capabilities.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56644/
-----------------------------------------------------------
(Updated Feb. 20, 2017, 3:18 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
Changes
-------
address bbannier's comments.
Summary (updated)
-----------------
Added a constant to store agent capabilities.
Bugs: MESOS-6902
https://issues.apache.org/jira/browse/MESOS-6902
Repository: mesos
Description (updated)
-------
Instead of hardcoding in code, agent capabilities are stored in a
constant and could be used by both agent initialization and http
response generation.
Diffs (updated)
-----
src/slave/constants.hpp 725689a51e7682218d34f1b0f6f1630140e2e2d0
src/slave/slave.cpp 7564e8d39530794131dbbc928fcbc59fb65ef471
Diff: https://reviews.apache.org/r/56644/diff/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 56644: Added a constant to store agent
capabilities.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56644/#review166224
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 20, 2017, 7:18 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56644/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2017, 7:18 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
>
>
> Bugs: MESOS-6902
> https://issues.apache.org/jira/browse/MESOS-6902
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Instead of hardcoding in code, agent capabilities are stored in a
> constant and could be used by both agent initialization and http
> response generation.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp 725689a51e7682218d34f1b0f6f1630140e2e2d0
> src/slave/slave.cpp 7564e8d39530794131dbbc928fcbc59fb65ef471
>
> Diff: https://reviews.apache.org/r/56644/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>