You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/02/07 03:16:49 UTC
Review Request 56370: Added a test to ensure multi-role framework
receiving offers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56370/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
Bugs: MESOS-7062
https://issues.apache.org/jira/browse/MESOS-7062
Repository: mesos
Description
-------
This test ensures that multi-role framework should receive offers for
each of its roles.
Diffs
-----
src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18
Diff: https://reviews.apache.org/r/56370/diff/
Testing
-------
Added a test.
make check GTEST_FILTER="MasterTest.MultiRoleFrameworkReceivesOffers"
Thanks,
Jay Guo
Re: Review Request 56370: Added a test to ensure multi-role framework
receiving offers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56370/#review164514
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56370]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 7, 2017, 7:29 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56370/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 7:29 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
>
>
> Bugs: MESOS-7062
> https://issues.apache.org/jira/browse/MESOS-7062
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test ensures that multi-role framework should receive offers for
> each of its roles.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18
>
> Diff: https://reviews.apache.org/r/56370/diff/
>
>
> Testing
> -------
>
> Added a test.
>
> make check GTEST_FILTER="MasterTest.MultiRoleFrameworkReceivesOffers"
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 56370: Added a test to ensure multi-role framework
receiving offers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56370/#review164885
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56370]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 9, 2017, 2:28 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56370/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 2:28 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
>
>
> Bugs: MESOS-7062
> https://issues.apache.org/jira/browse/MESOS-7062
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test ensures that multi-role framework should receive offers for
> each of its roles.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18
>
> Diff: https://reviews.apache.org/r/56370/diff/
>
>
> Testing
> -------
>
> Added a test.
>
> make check GTEST_FILTER="MasterTest.MultiRoleFrameworkReceivesOffers"
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 56370: Added a test to ensure multi-role framework
receiving offers.
Posted by Guangya Liu <gy...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56370/#review165229
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
src/tests/master_tests.cpp (line 6379)
<https://reviews.apache.org/r/56370/#comment237057>
s/->/.get().
src/tests/master_tests.cpp (line 6382)
<https://reviews.apache.org/r/56370/#comment237058>
ditto
- Guangya Liu
On \u4e8c\u6708 9, 2017, 2:28 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56370/
> -----------------------------------------------------------
>
> (Updated \u4e8c\u6708 9, 2017, 2:28 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
>
>
> Bugs: MESOS-7062
> https://issues.apache.org/jira/browse/MESOS-7062
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test ensures that multi-role framework should receive offers for
> each of its roles.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18
>
> Diff: https://reviews.apache.org/r/56370/diff/
>
>
> Testing
> -------
>
> Added a test.
>
> make check GTEST_FILTER="MasterTest.MultiRoleFrameworkReceivesOffers"
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 56370: Added a test to ensure multi-role framework
receiving offers.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56370/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 10:28 a.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
Changes
-------
rebase and address Michael's comment
Bugs: MESOS-7062
https://issues.apache.org/jira/browse/MESOS-7062
Repository: mesos
Description
-------
This test ensures that multi-role framework should receive offers for
each of its roles.
Diffs (updated)
-----
src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18
Diff: https://reviews.apache.org/r/56370/diff/
Testing
-------
Added a test.
make check GTEST_FILTER="MasterTest.MultiRoleFrameworkReceivesOffers"
Thanks,
Jay Guo
Re: Review Request 56370: Added a test to ensure multi-role framework
receiving offers.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56370/#review164814
-----------------------------------------------------------
Ship it!
src/tests/master_tests.cpp (lines 6343 - 6349)
<https://reviews.apache.org/r/56370/#comment236606>
Not sure why you need the `this->` here?
- Michael Park
On Feb. 6, 2017, 11:29 p.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56370/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 11:29 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
>
>
> Bugs: MESOS-7062
> https://issues.apache.org/jira/browse/MESOS-7062
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test ensures that multi-role framework should receive offers for
> each of its roles.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18
>
> Diff: https://reviews.apache.org/r/56370/diff/
>
>
> Testing
> -------
>
> Added a test.
>
> make check GTEST_FILTER="MasterTest.MultiRoleFrameworkReceivesOffers"
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 56370: Added a test to ensure multi-role framework
receiving offers.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56370/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 3:29 p.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
Bugs: MESOS-7062
https://issues.apache.org/jira/browse/MESOS-7062
Repository: mesos
Description
-------
This test ensures that multi-role framework should receive offers for
each of its roles.
Diffs (updated)
-----
src/tests/master_tests.cpp 3b4123b49ee32c902a5d2a01fcc7026da21fdd18
Diff: https://reviews.apache.org/r/56370/diff/
Testing
-------
Added a test.
make check GTEST_FILTER="MasterTest.MultiRoleFrameworkReceivesOffers"
Thanks,
Jay Guo