You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/02/07 07:14:33 UTC
Re: Review Request 52103: Implemented quota update through `PUT`
method.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52103/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 7:14 a.m.)
Review request for mesos, Alexander Rukletsov and Xiaojian Huang.
Changes
-------
Rebase.
Bugs: MESOS-4941
https://issues.apache.org/jira/browse/MESOS-4941
Repository: mesos
Description
-------
This patch implemented atomic quota update through
`PUT` methood on the `/quota` endpoint.
Changes included:
- a new virtual function on the allocator interface-
- implementation in hierarchical allocator;
- implementation in quota_handler;
- some integration tests for updating a quota.
More tests around resource rescind and operator API
implementation will be sent in later patches.
Diffs (updated)
-----
include/mesos/allocator/allocator.hpp 71a40537b673e44ecdd5327d9a9f083faa7fc13a
src/master/allocator/mesos/allocator.hpp e3c86181677302dbfc3b213715196122f96e312c
src/master/allocator/mesos/hierarchical.hpp 896abcdf0727f986eef3a1a9304a0e4847094057
src/master/allocator/mesos/hierarchical.cpp fc93ade661bedb6c915d1ee634b02cf28b9b24d9
src/master/http.cpp d881ad6dba9ba96057988db265faf0b3013c9b05
src/master/master.hpp a7e3c739f76d724070e1ae51c3093636a79e8008
src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a
src/tests/allocator.hpp 32c291213d18d1c8fe5d9e8194b92c10716b9961
src/tests/master_quota_tests.cpp b25f5911579c435549b9bc65994627414357dcb6
Diff: https://reviews.apache.org/r/52103/diff/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 52103: Implemented quota update in `/quota`
endpoint.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52103/
-----------------------------------------------------------
(Updated Aug. 5, 2017, 4:41 a.m.)
Review request for mesos, Alexander Rukletsov, Xiaojian Huang, and Neil Conway.
Changes
-------
Implement update through same `POST` method and `setQuota` functions.
Summary (updated)
-----------------
Implemented quota update in `/quota` endpoint.
Bugs: MESOS-4941
https://issues.apache.org/jira/browse/MESOS-4941
Repository: mesos
Description (updated)
-------
This patch implemented atomic quota update through
on the `/quota` endpoint by relaxing existing `setQuota`
functions in allocator interface.
Changes included:
- implementation in hierarchical allocator;
- implementation in quota_handler;
- some integration tests for updating a quota.
More tests around resource rescind and operator API
implementation will be sent in later patches.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035
src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70
src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043
src/master/quota_handler.cpp 26b2dc86fa44dfdf6e0a6c4993c754a6384dd851
src/tests/master_quota_tests.cpp 9d52f767c112abd55ab3f49d172eb6e3caea511b
Diff: https://reviews.apache.org/r/52103/diff/6/
Changes: https://reviews.apache.org/r/52103/diff/5-6/
Testing
-------
Thanks,
Zhitao Li
Re: Review Request 52103: Implemented quota update through `PUT`
method.
Posted by Zhitao Li <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52103/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 7:56 a.m.)
Review request for mesos, Alexander Rukletsov, Xiaojian Huang, and Neil Conway.
Changes
-------
Rebase.
Bugs: MESOS-4941
https://issues.apache.org/jira/browse/MESOS-4941
Repository: mesos
Description
-------
This patch implemented atomic quota update through
`PUT` methood on the `/quota` endpoint.
Changes included:
- a new virtual function on the allocator interface-
- implementation in hierarchical allocator;
- implementation in quota_handler;
- some integration tests for updating a quota.
More tests around resource rescind and operator API
implementation will be sent in later patches.
Diffs (updated)
-----
include/mesos/allocator/allocator.hpp 23413d1f9d76009c999b35d2bc98afc52c136404
src/master/allocator/mesos/allocator.hpp 38fbf16a0500fc9f6ce7a498a6af3d81d63fc215
src/master/allocator/mesos/hierarchical.hpp d33306745a7287b750cb4a5242c7527369d58d65
src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c
src/master/http.cpp c5324abc0db82275fd65d3f7d361ad8ee9e017d1
src/master/master.hpp 767ac48f2a65514a19c4a3f8ca7b35f0259f9aeb
src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a
src/tests/allocator.hpp c741a985660e1540ad8e3a9c387d513247e56714
src/tests/master_quota_tests.cpp d15c7aacb85596cdee7cf59c0c179247ba624fe5
Diff: https://reviews.apache.org/r/52103/diff/
Testing
-------
Thanks,
Zhitao Li