You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/02/02 23:05:16 UTC
Re: Review Request 55863: Introduce a helper for injecting
AllocationInfo into offer operations.
> On Jan. 28, 2017, 11:02 a.m., Guangya Liu wrote:
> > src/common/protobuf_utils.cpp, lines 345-347
> > <https://reviews.apache.org/r/55863/diff/1/?file=1613193#file1613193line345>
> >
> > Since we do not support one `Resources` store a mix of allocated and unallocated resources, how about optimize this a bit as:
> >
> > ```
> > if (resource->has_allocation_info()) {
> > break;
> > }
> >
> > resource->mutable_allocation_info()->CopyFrom(allocationInfo);
> > ```
> >
> > Ditto for here and everywhere
Well, we do support mixing in Resources, but we likely do not want to. I would like to have a stronger invariant that callers can't store a mix of allocated and unallocated resources, since I don't see a good reason for it and it's error prone.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55863/#review163396
-----------------------------------------------------------
On Jan. 23, 2017, 10:59 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55863/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 10:59 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Park.
>
>
> Bugs: MESOS-6967
> https://issues.apache.org/jira/browse/MESOS-6967
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, `Resource` did not contain `AllocationInfo`. So for
> backwards compatibility with old schedulers and tooling, we must
> allow operations to contain `Resource`s without an `AllocationInfo`.
>
> This introduces a function which allows the master to inject the
> offer's `AllocationInfo` into the operation's resources.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp faa7e2a759fd2b1ce5def662679f573ec6fefd28
> src/common/protobuf_utils.cpp dd20759affe3adf2867a33bf875c9ee82862038d
> src/tests/protobuf_utils_tests.cpp bc2a3d0ebe544a58d0de8f2f7174c170113ddf2e
>
> Diff: https://reviews.apache.org/r/55863/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Benjamin Mahler
>
>