You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/01 00:00:56 UTC
Re: Review Request 56139: Removed redundant 'Times(1)' from master
validation tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/
-----------------------------------------------------------
(Updated Feb. 1, 2017, midnight)
Review request for mesos and Vinod Kone.
Summary (updated)
-----------------
Removed redundant 'Times(1)' from master validation tests.
Repository: mesos
Description (updated)
-------
This patch removes calls to `.Times(1)` from `EXPECT_CALL`
invocations in the master validation tests because it is
redundant.
Diffs
-----
src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8
Diff: https://reviews.apache.org/r/56139/diff/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*Validation*"`
Thanks,
Greg Mann
Re: Review Request 56139: Removed redundant 'Times(1)' from master
validation tests.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/#review163951
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Feb. 1, 2017, 1 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56139/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 1 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes calls to `.Times(1)` from `EXPECT_CALL`
> invocations in the master validation tests because it is
> redundant.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8
>
> Diff: https://reviews.apache.org/r/56139/diff/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="*Validation*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56139: Removed redundant 'Times(1)' from master
validation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 11:24 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebase.
Repository: mesos
Description
-------
This patch removes calls to `.Times(1)` from `EXPECT_CALL`
invocations in the master validation tests because it is
redundant.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
Diff: https://reviews.apache.org/r/56139/diff/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*Validation*"`
Thanks,
Greg Mann
Re: Review Request 56139: Removed redundant 'Times(1)' from master
validation tests.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56139/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 6:35 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebase.
Repository: mesos
Description
-------
This patch removes calls to `.Times(1)` from `EXPECT_CALL`
invocations in the master validation tests because it is
redundant.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 0c2649089d7fd29eb021ac75c71e6a74368577dc
Diff: https://reviews.apache.org/r/56139/diff/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*Validation*"`
Thanks,
Greg Mann