You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/02/24 08:50:12 UTC
Review Request 57021: Added agent capabilities to `updateSlave`
method.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57021/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
Bugs: MESOS-7165
https://issues.apache.org/jira/browse/MESOS-7165
Repository: mesos
Description
-------
Master should be able to update agent capabilities stored in allocator
in case agent reboots to upgrade to MULTI_ROLE capable. `updateSlave`
is augmented to accept agent capabilities.
Diffs
-----
include/mesos/allocator/allocator.hpp 23413d1f9d76009c999b35d2bc98afc52c136404
src/master/allocator/mesos/allocator.hpp 38fbf16a0500fc9f6ce7a498a6af3d81d63fc215
src/master/allocator/mesos/hierarchical.hpp d33306745a7287b750cb4a5242c7527369d58d65
src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c
src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942
src/tests/allocator.hpp c741a985660e1540ad8e3a9c387d513247e56714
src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a
Diff: https://reviews.apache.org/r/57021/diff/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 57021: Added agent capabilities to `updateSlave`
method.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57021/#review166947
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/mesos/hierarchical.cpp (line 570)
<https://reviews.apache.org/r/57021/#comment239039>
Shouldn't this be set to true only if the capabilities have not changed?
src/master/allocator/mesos/hierarchical.cpp (lines 572 - 573)
<https://reviews.apache.org/r/57021/#comment239041>
Can we log which capabilities here?
src/master/allocator/mesos/hierarchical.cpp (line 600)
<https://reviews.apache.org/r/57021/#comment239040>
Shouldn't this be set to true only if the new oversubscribed resources are different than the previous oversubscribed resources?
- Benjamin Mahler
On Feb. 24, 2017, 8:50 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57021/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 8:50 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Guangya Liu, and Michael Park.
>
>
> Bugs: MESOS-7165
> https://issues.apache.org/jira/browse/MESOS-7165
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Master should be able to update agent capabilities stored in allocator
> in case agent reboots to upgrade to MULTI_ROLE capable. `updateSlave`
> is augmented to accept agent capabilities.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 23413d1f9d76009c999b35d2bc98afc52c136404
> src/master/allocator/mesos/allocator.hpp 38fbf16a0500fc9f6ce7a498a6af3d81d63fc215
> src/master/allocator/mesos/hierarchical.hpp d33306745a7287b750cb4a5242c7527369d58d65
> src/master/allocator/mesos/hierarchical.cpp eeb44fe89d4bfd26900b11833c1182157e5c7e5c
> src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942
> src/tests/allocator.hpp c741a985660e1540ad8e3a9c387d513247e56714
> src/tests/hierarchical_allocator_tests.cpp 5441fa9d1fad1ca7819038db49c6d88e40571e4a
>
> Diff: https://reviews.apache.org/r/57021/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>