You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/02/28 20:18:16 UTC
Review Request 57165: Minor cleanup for quota validation code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57165/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Michael Park.
Repository: mesos
Description
-------
Minor cleanup for quota validation code.
Diffs
-----
src/master/quota.cpp 847ec068f4f3fe94ddabc11ff583d7e76117d375
Diff: https://reviews.apache.org/r/57165/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 57165: Minor cleanup for quota validation code.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57165/#review167247
-----------------------------------------------------------
Fix it, then Ship it!
src/master/quota.cpp
Line 147 (original), 142 (patched)
<https://reviews.apache.org/r/57165/#comment239400>
How about: "Check that `resource` does not contain fields irrelevant for quota."?
- Benjamin Bannier
On Feb. 28, 2017, 9:18 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57165/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 9:18 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Minor cleanup for quota validation code.
>
>
> Diffs
> -----
>
> src/master/quota.cpp 847ec068f4f3fe94ddabc11ff583d7e76117d375
>
>
> Diff: https://reviews.apache.org/r/57165/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 57165: Minor cleanup for quota validation code.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57165/#review168068
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On March 1, 2017, 10:23 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57165/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 10:23 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Minor cleanup for quota validation code.
>
>
> Diffs
> -----
>
> src/master/quota.cpp 847ec068f4f3fe94ddabc11ff583d7e76117d375
>
>
> Diff: https://reviews.apache.org/r/57165/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 57165: Minor cleanup for quota validation code.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57165/
-----------------------------------------------------------
(Updated March 9, 2017, 4:36 p.m.)
Review request for mesos, Benjamin Bannier and Michael Park.
Changes
-------
Fix whitespace error.
Repository: mesos
Description
-------
Minor cleanup for quota validation code.
Diffs (updated)
-----
src/master/quota.cpp 847ec068f4f3fe94ddabc11ff583d7e76117d375
src/master/quota_handler.cpp ce1f0644a56e85a99d8c3742d00940a1bfae3be3
Diff: https://reviews.apache.org/r/57165/diff/4/
Changes: https://reviews.apache.org/r/57165/diff/3-4/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 57165: Minor cleanup for quota validation code.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57165/
-----------------------------------------------------------
(Updated March 1, 2017, 6:23 p.m.)
Review request for mesos, Benjamin Bannier and Michael Park.
Changes
-------
Tweak.
Repository: mesos
Description
-------
Minor cleanup for quota validation code.
Diffs (updated)
-----
src/master/quota.cpp 847ec068f4f3fe94ddabc11ff583d7e76117d375
Diff: https://reviews.apache.org/r/57165/diff/3/
Changes: https://reviews.apache.org/r/57165/diff/2-3/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 57165: Minor cleanup for quota validation code.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57165/
-----------------------------------------------------------
(Updated March 1, 2017, 6:07 p.m.)
Review request for mesos, Benjamin Bannier and Michael Park.
Changes
-------
Address review comment.
Repository: mesos
Description
-------
Minor cleanup for quota validation code.
Diffs (updated)
-----
src/master/quota.cpp 847ec068f4f3fe94ddabc11ff583d7e76117d375
Diff: https://reviews.apache.org/r/57165/diff/2/
Changes: https://reviews.apache.org/r/57165/diff/1-2/
Testing
-------
`make check`
Thanks,
Neil Conway