You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/14 00:15:09 UTC
Review Request 56624: Updated libprocess tests to use
'AuthenticationContext'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56624/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP-related libprocess
tests to use authenticated handlers which accept
an `AuthenticationContext` instead of an
`Option<string> principal`.
Diffs
-----
3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f
Diff: https://reviews.apache.org/r/56624/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56624: Updated libprocess tests to use the
'Principal' type.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56624/#review167909
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 28, 2017, 6:59 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56624/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 6:59 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP-related libprocess
> tests to use authenticated handlers which accept
> the `Principal` type instead of an
> `Option<string> principal`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f
>
>
> Diff: https://reviews.apache.org/r/56624/diff/3/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56624: Updated libprocess tests to use the
'Principal' type.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56624/#review167072
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/tests/http_tests.cpp (line 1776)
<https://reviews.apache.org/r/56624/#comment239199>
`/Option<Principal>::none()/None()/`
Not so sure if it works in macros, but I did test changing it in the previous commit and compiling it.
- Alexander Rojas
On Feb. 28, 2017, 7:59 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56624/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 7:59 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP-related libprocess
> tests to use authenticated handlers which accept
> the `Principal` type instead of an
> `Option<string> principal`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f
>
> Diff: https://reviews.apache.org/r/56624/diff/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56624: Updated libprocess tests to use the
'Principal' type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56624/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 6:59 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Changed 'AuthenticationContext' to 'Principal'.
Summary (updated)
-----------------
Updated libprocess tests to use the 'Principal' type.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description (updated)
-------
This patch updates the HTTP-related libprocess
tests to use authenticated handlers which accept
the `Principal` type instead of an
`Option<string> principal`.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f
Diff: https://reviews.apache.org/r/56624/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56624: Updated libprocess tests to use
'AuthenticationContext'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56624/
-----------------------------------------------------------
(Updated Feb. 18, 2017, 3:04 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP-related libprocess
tests to use authenticated handlers which accept
an `AuthenticationContext` instead of an
`Option<string> principal`.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/http_tests.cpp fb4da9aecff0370d97a15269c5d8fffb30e0478f
Diff: https://reviews.apache.org/r/56624/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann