You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/02/08 23:35:44 UTC
Review Request 56465: Add support for the ELF .interp section.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56465/
-----------------------------------------------------------
Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
Bugs: MESOS-7060
https://issues.apache.org/jira/browse/MESOS-7060
Repository: mesos
Description
-------
Add support for the ELF .interp section.
Diffs
-----
3rdparty/stout/include/stout/elf.hpp 2bf91a0c5ea0b0cac74a844345b0ce13777f1edb
Diff: https://reviews.apache.org/r/56465/diff/
Testing
-------
make check (Fedora, Ubuntu)
Thanks,
James Peach
Re: Review Request 56465: Add support for the ELF .interp section.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56465/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 8:03 p.m.)
Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
Bugs: MESOS-7060
https://issues.apache.org/jira/browse/MESOS-7060
Repository: mesos
Description
-------
Add support for the ELF .interp section.
Diffs (updated)
-----
3rdparty/stout/include/stout/elf.hpp 2bf91a0c5ea0b0cac74a844345b0ce13777f1edb
Diff: https://reviews.apache.org/r/56465/diff/
Testing
-------
make check (Fedora, Ubuntu)
Thanks,
James Peach
Re: Review Request 56465: Add support for the ELF .interp section.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56465/#review164876
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/stout/include/stout/elf.hpp (line 215)
<https://reviews.apache.org/r/56465/#comment236790>
Nit: s/section// to be consistent with the error messages in `get_*`s.
- Jiang Yan Xu
On Feb. 9, 2017, 9:20 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56465/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2017, 9:20 a.m.)
>
>
> Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7060
> https://issues.apache.org/jira/browse/MESOS-7060
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add support for the ELF .interp section.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/elf.hpp 2bf91a0c5ea0b0cac74a844345b0ce13777f1edb
>
> Diff: https://reviews.apache.org/r/56465/diff/
>
>
> Testing
> -------
>
> make check (Fedora, Ubuntu)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 56465: Add support for the ELF .interp section.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56465/
-----------------------------------------------------------
(Updated Feb. 9, 2017, 5:20 p.m.)
Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
Bugs: MESOS-7060
https://issues.apache.org/jira/browse/MESOS-7060
Repository: mesos
Description
-------
Add support for the ELF .interp section.
Diffs (updated)
-----
3rdparty/stout/include/stout/elf.hpp 2bf91a0c5ea0b0cac74a844345b0ce13777f1edb
Diff: https://reviews.apache.org/r/56465/diff/
Testing
-------
make check (Fedora, Ubuntu)
Thanks,
James Peach
Re: Review Request 56465: Add support for the ELF .interp section.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56465/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 11:50 p.m.)
Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
Bugs: MESOS-7060
https://issues.apache.org/jira/browse/MESOS-7060
Repository: mesos
Description
-------
Add support for the ELF .interp section.
Diffs (updated)
-----
3rdparty/stout/include/stout/elf.hpp 2bf91a0c5ea0b0cac74a844345b0ce13777f1edb
Diff: https://reviews.apache.org/r/56465/diff/
Testing
-------
make check (Fedora, Ubuntu)
Thanks,
James Peach