You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/02/16 15:37:41 UTC
Review Request 56413: WIP Support pausing/resuming health checks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56413/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
Bugs: MESOS-6280
https://issues.apache.org/jira/browse/MESOS-6280
Repository: mesos
Description
-------
WIP Support pausing/resuming health checks.
Diffs
-----
src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5
src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1
src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691
src/launcher/default_executor.cpp d97324b0e5eb3f145ee93aa0821205c5eefbfce0
src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
Diff: https://reviews.apache.org/r/56413/diff/
Testing
-------
Thanks,
Gast�n Kleiman
Re: Review Request 56413: WIP Support pausing/resuming health checks.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56413/#review165873
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55900, 56288, 55901, 56413]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 16, 2017, 3:37 p.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56413/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 3:37 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6280
> https://issues.apache.org/jira/browse/MESOS-6280
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP Support pausing/resuming health checks.
>
>
> Diffs
> -----
>
> src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5
> src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1
> src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691
> src/launcher/default_executor.cpp d97324b0e5eb3f145ee93aa0821205c5eefbfce0
> src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
>
> Diff: https://reviews.apache.org/r/56413/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 56413: WIP Support pausing/resuming health checks.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56413/#review165932
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55900, 56288, 55901, 56413]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 17, 2017, 12:01 p.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56413/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 12:01 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6280
> https://issues.apache.org/jira/browse/MESOS-6280
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP Support pausing/resuming health checks.
>
>
> Diffs
> -----
>
> src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5
> src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1
> src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691
> src/launcher/default_executor.cpp d97324b0e5eb3f145ee93aa0821205c5eefbfce0
> src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
>
> Diff: https://reviews.apache.org/r/56413/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 56413: WIP Support pausing/resuming health checks.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56413/
-----------------------------------------------------------
(Updated Feb. 17, 2017, 12:01 p.m.)
Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-6280
https://issues.apache.org/jira/browse/MESOS-6280
Repository: mesos
Description
-------
WIP Support pausing/resuming health checks.
Diffs (updated)
-----
src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5
src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1
src/docker/executor.cpp d8c72b081fb9a37b3927b73cea3b47956a076691
src/launcher/default_executor.cpp d97324b0e5eb3f145ee93aa0821205c5eefbfce0
src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969
Diff: https://reviews.apache.org/r/56413/diff/
Testing
-------
Thanks,
Gast�n Kleiman