You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2017/02/28 01:35:03 UTC

Review Request 57117: Added nested container launch/wait/kill APIs to agent API docs.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57117/
-----------------------------------------------------------

Review request for mesos, Adam B, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-7189
    https://issues.apache.org/jira/browse/MESOS-7189


Repository: mesos


Description
-------

Added nested container launch/wait/kill APIs to agent API docs.


Diffs
-----

  docs/operator-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c 

Diff: https://reviews.apache.org/r/57117/diff/


Testing
-------


Thanks,

Kevin Klues


Re: Review Request 57117: Added nested container launch/wait/kill APIs to agent API docs.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57117/#review167119
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Feb. 28, 2017, 6:08 p.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57117/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 6:08 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7189
>     https://issues.apache.org/jira/browse/MESOS-7189
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added nested container launch/wait/kill APIs to agent API docs.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c 
> 
> Diff: https://reviews.apache.org/r/57117/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Re: Review Request 57117: Added nested container launch/wait/kill APIs to agent API docs.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57117/
-----------------------------------------------------------

(Updated Feb. 28, 2017, 6:08 p.m.)


Review request for mesos, Adam B, Benjamin Mahler, and Vinod Kone.


Changes
-------

Updated based on Vinod's comments.


Bugs: MESOS-7189
    https://issues.apache.org/jira/browse/MESOS-7189


Repository: mesos


Description
-------

Added nested container launch/wait/kill APIs to agent API docs.


Diffs (updated)
-----

  docs/operator-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c 

Diff: https://reviews.apache.org/r/57117/diff/


Testing
-------


Thanks,

Kevin Klues


Re: Review Request 57117: Added nested container launch/wait/kill APIs to agent API docs.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57117/#review167105
-----------------------------------------------------------




docs/operator-http-api.md (line 3237)
<https://reviews.apache.org/r/57117/#comment239232>

    This API doesn't mandate task groups right?
    
    s/as part of a task group/under an existing parent container/.



docs/operator-http-api.md (line 3306)
<https://reviews.apache.org/r/57117/#comment239233>

    can you use a different uuid than the parent's?



docs/operator-http-api.md (line 3348)
<https://reviews.apache.org/r/57117/#comment239234>

    can you use a different uuid than the parent's?


- Vinod Kone


On Feb. 28, 2017, 1:35 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57117/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2017, 1:35 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7189
>     https://issues.apache.org/jira/browse/MESOS-7189
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added nested container launch/wait/kill APIs to agent API docs.
> 
> 
> Diffs
> -----
> 
>   docs/operator-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c 
> 
> Diff: https://reviews.apache.org/r/57117/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>