You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/02/07 02:31:31 UTC
Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB` parent
hook.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56368/
-----------------------------------------------------------
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-6892
https://issues.apache.org/jira/browse/MESOS-6892
Repository: mesos
Description
-------
Libprocess: Windows: Remove `CREATE_JOB` parent hook.
Diffs
-----
3rdparty/libprocess/src/subprocess.cpp bc1b99b8f84332f42623c35fc2b8d5186ba8af70
Diff: https://reviews.apache.org/r/56368/diff/
Testing
-------
This is the last patch in a series. Applied all together, they were tested with `make && make check` on Linux, and `support\windows-build.bat` on Windows. All tests pass (minus flaky ones which sometimes fail but that's unrelated).
Thanks,
Andrew Schwartzmeyer
Re: Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB`
parent hook.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Feb. 7, 2017, 11:37 a.m., Ilya Pronin wrote:
> > The declaration of `ParentHook::CREATE_JOB()` in `subprocess_base.hpp` should also be removed.
Good catch, thanks! This code had been added between my work and when I had to rebase it, so I missed this part.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56368/#review164494
-----------------------------------------------------------
On Feb. 7, 2017, 2:31 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56368/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 2:31 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-6892
> https://issues.apache.org/jira/browse/MESOS-6892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: Windows: Remove `CREATE_JOB` parent hook.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp bc1b99b8f84332f42623c35fc2b8d5186ba8af70
>
> Diff: https://reviews.apache.org/r/56368/diff/
>
>
> Testing
> -------
>
> This is the last patch in a series. Applied all together, they were tested with `make && make check` on Linux, and `support\windows-build.bat` on Windows. All tests pass (minus flaky ones which sometimes fail but that's unrelated).
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB`
parent hook.
Posted by Ilya Pronin <ip...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56368/#review164494
-----------------------------------------------------------
The declaration of `ParentHook::CREATE_JOB()` in `subprocess_base.hpp` should also be removed.
- Ilya Pronin
On Feb. 7, 2017, 2:31 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56368/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 2:31 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-6892
> https://issues.apache.org/jira/browse/MESOS-6892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: Windows: Remove `CREATE_JOB` parent hook.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp bc1b99b8f84332f42623c35fc2b8d5186ba8af70
>
> Diff: https://reviews.apache.org/r/56368/diff/
>
>
> Testing
> -------
>
> This is the last patch in a series. Applied all together, they were tested with `make && make check` on Linux, and `support\windows-build.bat` on Windows. All tests pass (minus flaky ones which sometimes fail but that's unrelated).
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB`
parent hook.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56368/#review165589
-----------------------------------------------------------
Test again review bot!
- Andrew Schwartzmeyer
On Feb. 8, 2017, 9:15 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56368/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 9:15 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-6892
> https://issues.apache.org/jira/browse/MESOS-6892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: Windows: Remove `CREATE_JOB` parent hook.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess_base.hpp 7117a2730ae8666d0b55cbe05162a0b4e843193c
> 3rdparty/libprocess/src/subprocess.cpp bc1b99b8f84332f42623c35fc2b8d5186ba8af70
>
> Diff: https://reviews.apache.org/r/56368/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB`
parent hook.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Feb. 9, 2017, 12:23 a.m., Mesos Reviewbot wrote:
> > Bad review!
> >
> > Reviews applied: [56368, 56362, 56364, 56363]
> >
> > Error:
> > Circular dependency detected for review 56363.Please fix the 'depends_on' field.
Reviewbot, try again! You failed.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56368/#review164816
-----------------------------------------------------------
On Feb. 8, 2017, 9:15 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56368/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 9:15 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-6892
> https://issues.apache.org/jira/browse/MESOS-6892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: Windows: Remove `CREATE_JOB` parent hook.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess_base.hpp 7117a2730ae8666d0b55cbe05162a0b4e843193c
> 3rdparty/libprocess/src/subprocess.cpp bc1b99b8f84332f42623c35fc2b8d5186ba8af70
>
> Diff: https://reviews.apache.org/r/56368/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB`
parent hook.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56368/#review164816
-----------------------------------------------------------
Bad review!
Reviews applied: [56368, 56362, 56364, 56363]
Error:
Circular dependency detected for review 56363.Please fix the 'depends_on' field.
- Mesos Reviewbot
On Feb. 8, 2017, 9:15 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56368/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 9:15 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-6892
> https://issues.apache.org/jira/browse/MESOS-6892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Libprocess: Windows: Remove `CREATE_JOB` parent hook.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/subprocess_base.hpp 7117a2730ae8666d0b55cbe05162a0b4e843193c
> 3rdparty/libprocess/src/subprocess.cpp bc1b99b8f84332f42623c35fc2b8d5186ba8af70
>
> Diff: https://reviews.apache.org/r/56368/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB`
parent hook.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56368/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 9:15 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Changes
-------
Fix the patch dependency.
Bugs: MESOS-6892
https://issues.apache.org/jira/browse/MESOS-6892
Repository: mesos
Description
-------
Libprocess: Windows: Remove `CREATE_JOB` parent hook.
Diffs
-----
3rdparty/libprocess/include/process/subprocess_base.hpp 7117a2730ae8666d0b55cbe05162a0b4e843193c
3rdparty/libprocess/src/subprocess.cpp bc1b99b8f84332f42623c35fc2b8d5186ba8af70
Diff: https://reviews.apache.org/r/56368/diff/
Testing (updated)
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 56368: Libprocess: Windows: Remove `CREATE_JOB`
parent hook.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56368/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 6:56 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Changes
-------
Remove declaration of `CREATE_JOB` too.
Bugs: MESOS-6892
https://issues.apache.org/jira/browse/MESOS-6892
Repository: mesos
Description (updated)
-------
Libprocess: Windows: Remove `CREATE_JOB` parent hook.
Diffs (updated)
-----
3rdparty/libprocess/include/process/subprocess_base.hpp 7117a2730ae8666d0b55cbe05162a0b4e843193c
3rdparty/libprocess/src/subprocess.cpp bc1b99b8f84332f42623c35fc2b8d5186ba8af70
Diff: https://reviews.apache.org/r/56368/diff/
Testing
-------
This is the last patch in a series. Applied all together, they were tested with `make && make check` on Linux, and `support\windows-build.bat` on Windows. All tests pass (minus flaky ones which sometimes fail but that's unrelated).
Thanks,
Andrew Schwartzmeyer