You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/02/18 01:55:07 UTC
Review Request 56809: Added test for nested container machine reboot
case.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/
-----------------------------------------------------------
Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
Repository: mesos
Description
-------
Added test for nested container machine reboot case.
Diffs
-----
src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c
Diff: https://reviews.apache.org/r/56809/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56809: Added test for nested container machine
reboot case.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/#review166021
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56808, 56809]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 18, 2017, 1:55 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56809/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2017, 1:55 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for nested container machine reboot case.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c
>
> Diff: https://reviews.apache.org/r/56809/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56809: Added test for nested container machine
reboot case.
Posted by Gilbert Song <so...@gmail.com>.
> On Feb. 19, 2017, 8:32 p.m., Jie Yu wrote:
> > src/tests/containerizer/nested_mesos_containerizer_tests.cpp, lines 998-1012
> > <https://reviews.apache.org/r/56809/diff/1/?file=1639897#file1639897line998>
> >
> > Instead of that, can we call 'provisioner->provision' and use DockerArchive as the local docker store?
Updated depending on this comment. I move the test to `provisioner_docker_tests.cpp` since containerizer construction method is needed if we want to call `provisioner->provision()`. It is a little more work to be done. Please let me know if it looks complicated and we should change it back.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/#review166047
-----------------------------------------------------------
On Feb. 17, 2017, 5:55 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56809/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 5:55 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for nested container machine reboot case.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c
>
> Diff: https://reviews.apache.org/r/56809/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56809: Added test for nested container machine
reboot case.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/#review166047
-----------------------------------------------------------
src/tests/containerizer/nested_mesos_containerizer_tests.cpp (lines 998 - 1012)
<https://reviews.apache.org/r/56809/#comment237953>
Instead of that, can we call 'provisioner->provision' and use DockerArchive as the local docker store?
src/tests/containerizer/nested_mesos_containerizer_tests.cpp (line 1014)
<https://reviews.apache.org/r/56809/#comment237954>
Do you want to check if provisioner dir has been cleaned up?
- Jie Yu
On Feb. 18, 2017, 1:55 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56809/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2017, 1:55 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for nested container machine reboot case.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c
>
> Diff: https://reviews.apache.org/r/56809/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56809: Added test for nested container machine
reboot case.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/#review166317
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56808, 56809]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 21, 2017, 10:34 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56809/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 10:34 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7152
> https://issues.apache.org/jira/browse/MESOS-7152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for nested container machine reboot case.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp ce57c06d50b47a150ff40412c1fde99f16892434
>
> Diff: https://reviews.apache.org/r/56809/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56809: Added test for nested container agent
reboot case.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/#review166407
-----------------------------------------------------------
src/tests/containerizer/nested_mesos_containerizer_tests.cpp (lines 988 - 1000)
<https://reviews.apache.org/r/56809/#comment238329>
Why you need to create the containerizer here?
src/tests/containerizer/nested_mesos_containerizer_tests.cpp (line 1015)
<https://reviews.apache.org/r/56809/#comment238330>
Can you just call provisioner->recover()?
- Jie Yu
On Feb. 22, 2017, 7:17 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56809/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 7:17 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7152
> https://issues.apache.org/jira/browse/MESOS-7152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for nested container agent reboot case.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c
>
> Diff: https://reviews.apache.org/r/56809/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56809: Added test for nested container agent
reboot case.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/#review166459
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 23, 2017, 1:05 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56809/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 1:05 a.m.)
>
>
> Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7152
> https://issues.apache.org/jira/browse/MESOS-7152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for nested container agent reboot case.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp ce57c06d50b47a150ff40412c1fde99f16892434
>
> Diff: https://reviews.apache.org/r/56809/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56809: Added test for nested container agent
reboot case.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 6:33 p.m.)
Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
Bugs: MESOS-7152
https://issues.apache.org/jira/browse/MESOS-7152
Repository: mesos
Description
-------
Added test for nested container agent reboot case.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp ce57c06d50b47a150ff40412c1fde99f16892434
Diff: https://reviews.apache.org/r/56809/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56809: Added test for nested container agent
reboot case.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 5:05 p.m.)
Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
Bugs: MESOS-7152
https://issues.apache.org/jira/browse/MESOS-7152
Repository: mesos
Description
-------
Added test for nested container agent reboot case.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp ce57c06d50b47a150ff40412c1fde99f16892434
Diff: https://reviews.apache.org/r/56809/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56809: Added test for nested container agent
reboot case.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 11:17 a.m.)
Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
Summary (updated)
-----------------
Added test for nested container agent reboot case.
Bugs: MESOS-7152
https://issues.apache.org/jira/browse/MESOS-7152
Repository: mesos
Description (updated)
-------
Added test for nested container agent reboot case.
Diffs (updated)
-----
src/tests/containerizer/nested_mesos_containerizer_tests.cpp ea01fe55a28d17105157004d8cf0976202a49b7c
Diff: https://reviews.apache.org/r/56809/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56809: Added test for nested container machine
reboot case.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/#review166374
-----------------------------------------------------------
src/tests/containerizer/provisioner_docker_tests.cpp (lines 409 - 411)
<https://reviews.apache.org/r/56809/#comment238306>
Why you need to initialize a containerizer? can you just use provisioner?
- Jie Yu
On Feb. 21, 2017, 10:34 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56809/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2017, 10:34 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
>
>
> Bugs: MESOS-7152
> https://issues.apache.org/jira/browse/MESOS-7152
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test for nested container machine reboot case.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp ce57c06d50b47a150ff40412c1fde99f16892434
>
> Diff: https://reviews.apache.org/r/56809/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 56809: Added test for nested container machine
reboot case.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/
-----------------------------------------------------------
(Updated Feb. 21, 2017, 2:34 p.m.)
Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
Bugs: MESOS-7152
https://issues.apache.org/jira/browse/MESOS-7152
Repository: mesos
Description
-------
Added test for nested container machine reboot case.
Diffs
-----
src/tests/containerizer/provisioner_docker_tests.cpp ce57c06d50b47a150ff40412c1fde99f16892434
Diff: https://reviews.apache.org/r/56809/diff/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 56809: Added test for nested container machine
reboot case.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56809/
-----------------------------------------------------------
(Updated Feb. 21, 2017, 2 p.m.)
Review request for mesos, Avinash sridharan, Jie Yu, and Kevin Klues.
Repository: mesos
Description
-------
Added test for nested container machine reboot case.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp ce57c06d50b47a150ff40412c1fde99f16892434
Diff: https://reviews.apache.org/r/56809/diff/
Testing
-------
make check
Thanks,
Gilbert Song