You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/02/01 21:01:04 UTC
Re: Review Request 55971: Updated the agent to be MULTI_ROLE capable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55971/#review163876
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp (lines 5227 - 5229)
<https://reviews.apache.org/r/55971/#comment235358>
Could we add a note here about how checking for `MULTI_ROLE` capabitility isn't sufficient since there could be tasks persisted from before a framework upgrade? I find it pretty tricky, and worth noting.
- Michael Park
On Jan. 26, 2017, 4:27 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55971/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Park.
>
>
> Bugs: MESOS-6964
> https://issues.apache.org/jira/browse/MESOS-6964
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the addition of MULTI_ROLE support, the agent needs to ensure
> that allocated resources reported to the master have the
> `Resource.AllocationInfo` set. The approach taken here is to set
> it only in memory upon recovering tasks and executors. Note that
> once we allow a framework to modify its roles, we need to update
> the agent to re-persist the resources with injected allocation
> info (rather than just setting it in memory).
>
>
> Diffs
> -----
>
> src/slave/resource_estimators/fixed.cpp 2c1268c3423091c6a419020a3af97255de55db0a
> src/slave/slave.cpp 0548b04073c0ba4adfc4433d75fd18c2ba79d891
>
> Diff: https://reviews.apache.org/r/55971/diff/
>
>
> Testing
> -------
>
> The tests pass at the end of this review chain.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 55971: Updated the agent to be MULTI_ROLE capable.
Posted by Benjamin Mahler <bm...@apache.org>.
> On Feb. 1, 2017, 9:01 p.m., Michael Park wrote:
> > src/slave/slave.cpp, lines 5227-5229
> > <https://reviews.apache.org/r/55971/diff/2/?file=1617172#file1617172line5227>
> >
> > Could we add a note here about how checking for `MULTI_ROLE` capabitility isn't sufficient since there could be tasks persisted from before a framework upgrade? I find it pretty tricky, and worth noting.
Good point, will do.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55971/#review163876
-----------------------------------------------------------
On Jan. 27, 2017, 12:27 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55971/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 12:27 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael Park.
>
>
> Bugs: MESOS-6964
> https://issues.apache.org/jira/browse/MESOS-6964
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the addition of MULTI_ROLE support, the agent needs to ensure
> that allocated resources reported to the master have the
> `Resource.AllocationInfo` set. The approach taken here is to set
> it only in memory upon recovering tasks and executors. Note that
> once we allow a framework to modify its roles, we need to update
> the agent to re-persist the resources with injected allocation
> info (rather than just setting it in memory).
>
>
> Diffs
> -----
>
> src/slave/resource_estimators/fixed.cpp 2c1268c3423091c6a419020a3af97255de55db0a
> src/slave/slave.cpp 0548b04073c0ba4adfc4433d75fd18c2ba79d891
>
> Diff: https://reviews.apache.org/r/55971/diff/
>
>
> Testing
> -------
>
> The tests pass at the end of this review chain.
>
>
> Thanks,
>
> Benjamin Mahler
>
>