Re: Review Request 55686: Added custom target for 'make distcheck'.

[Joseph Wu <jo...@mesosphere.io>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55686/#review167150
-----------------------------------------------------------



I'm going to discard this, mostly because there is no canonical way for `${CMAKE_MAKE_PROGRAM}` to inherit the options of the caller.  i.e. `make -j8 ...`  This is further complicated by the number of `CMAKE_GENERATOR`s that exist (Ninja, MSVC, etc).

Basically, we would currently be better off running `distcheck` manually, because the caller can specify parallelism or other options as needed.

- Joseph Wu


On Jan. 18, 2017, 2:25 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55686/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 2:25 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5433
>     https://issues.apache.org/jira/browse/MESOS-5433
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added custom target for 'make distcheck'.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f 
> 
> Diff: https://reviews.apache.org/r/55686/diff/
> 
> 
> Testing
> -------
> 
> make dist
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>