You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/02/06 19:29:42 UTC
Re: Review Request 54650: Added validation for roles in ACCEPT call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54650/#review164393
-----------------------------------------------------------
Fix it, then Ship it!
There seems to be a bug, otherwise looks good.
Feel free to split out the offer id printing fix.
src/master/validation.cpp (line 1308)
<https://reviews.apache.org/r/54650/#comment236083>
If you want to pull these two consistency fixes out I could get that committed for you.
src/master/validation.cpp (line 1401)
<https://reviews.apache.org/r/54650/#comment236085>
How about validateAllocationRole?
src/master/validation.cpp (line 1415)
<https://reviews.apache.org/r/54650/#comment236084>
This line looks wrong? You could replace it with a 'continue' but it's also fine if you just remove it.
- Benjamin Mahler
On Dec. 13, 2016, 4:41 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54650/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 4:41 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu.
>
>
> Bugs: MESOS-6637
> https://issues.apache.org/jira/browse/MESOS-6637
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For a multi-role framework, it may receive offers for different roles
> in that framework. However, we disallow multiple offers with different
> roles being accepted in single ACCEPT call.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f
>
> Diff: https://reviews.apache.org/r/54650/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>