You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/02/18 00:18:07 UTC
Review Request 56806: Fixed some clang-tidy warnings.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56806/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Mostly avoiding spurious copies.
Diffs
-----
src/common/protobuf_utils.cpp 442184920521f372c535426f49155cb19980bf6d
src/master/detector/detector.cpp 1ebe5af4219a7e1ec1cbf22b440dd3ecaad4b4a9
src/slave/slave.cpp 7564e8d39530794131dbbc928fcbc59fb65ef471
src/tests/containerizer/docker_containerizer_tests.cpp 31d63b1f239055d82470ace9024b584a2096dce4
src/tests/fetcher_cache_tests.cpp e5eee9bce56edacb74ad80ff859ddbc5048c73d0
src/tests/hook_tests.cpp 237df8102941cd143c4d61016963e62a69c43382
src/tests/persistent_volume_endpoints_tests.cpp ec8df33a3f0d4ad790d5cc753e1691c5517c39c0
Diff: https://reviews.apache.org/r/56806/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56806: Fixed some clang-tidy warnings.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56806/#review167128
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/docker_containerizer_tests.cpp (line 2982)
<https://reviews.apache.org/r/56806/#comment239273>
Looks like this one only has 1 use as well. It seems like rest of the places you just replaced the 1 use with `offer.slave_id()`.
- Michael Park
On Feb. 28, 2017, 11:13 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56806/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 11:13 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed some clang-tidy warnings.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 944263bbaa87a65005fd924bccfadb7293312fa0
> src/master/detector/detector.cpp 1ebe5af4219a7e1ec1cbf22b440dd3ecaad4b4a9
> src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
> src/tests/containerizer/docker_containerizer_tests.cpp e760f47b3d8c4054bad8ff65269107d5583c9a90
> src/tests/fetcher_cache_tests.cpp e5eee9bce56edacb74ad80ff859ddbc5048c73d0
> src/tests/hook_tests.cpp 237df8102941cd143c4d61016963e62a69c43382
> src/tests/persistent_volume_endpoints_tests.cpp 1cc6c9d01a3a473f5a44210ea725310ea5931ff6
>
> Diff: https://reviews.apache.org/r/56806/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56806: Fixed some clang-tidy warnings.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56806/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 8:07 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Address review comments, more minor cleanup.
Repository: mesos
Description
-------
Fixed some clang-tidy warnings.
Diffs (updated)
-----
src/common/protobuf_utils.cpp 944263bbaa87a65005fd924bccfadb7293312fa0
src/master/detector/detector.cpp 1ebe5af4219a7e1ec1cbf22b440dd3ecaad4b4a9
src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
src/tests/containerizer/docker_containerizer_tests.cpp e760f47b3d8c4054bad8ff65269107d5583c9a90
src/tests/fetcher_cache_tests.cpp e5eee9bce56edacb74ad80ff859ddbc5048c73d0
src/tests/gc_tests.cpp 293c1461a5fbdb5a3d3098290fa5c1d21e15c85e
src/tests/hook_tests.cpp 237df8102941cd143c4d61016963e62a69c43382
src/tests/partition_tests.cpp 105157deaa500642a490b8bda0624629035a95a5
src/tests/persistent_volume_endpoints_tests.cpp 1cc6c9d01a3a473f5a44210ea725310ea5931ff6
Diff: https://reviews.apache.org/r/56806/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56806: Fixed some clang-tidy warnings.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56806/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 7:13 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Tweak commit message.
Repository: mesos
Description (updated)
-------
Fixed some clang-tidy warnings.
Diffs (updated)
-----
src/common/protobuf_utils.cpp 944263bbaa87a65005fd924bccfadb7293312fa0
src/master/detector/detector.cpp 1ebe5af4219a7e1ec1cbf22b440dd3ecaad4b4a9
src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a
src/tests/containerizer/docker_containerizer_tests.cpp e760f47b3d8c4054bad8ff65269107d5583c9a90
src/tests/fetcher_cache_tests.cpp e5eee9bce56edacb74ad80ff859ddbc5048c73d0
src/tests/hook_tests.cpp 237df8102941cd143c4d61016963e62a69c43382
src/tests/persistent_volume_endpoints_tests.cpp 1cc6c9d01a3a473f5a44210ea725310ea5931ff6
Diff: https://reviews.apache.org/r/56806/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56806: Fixed some clang-tidy warnings.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56806/#review166020
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56806]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 18, 2017, 12:18 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56806/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2017, 12:18 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Mostly avoiding spurious copies.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.cpp 442184920521f372c535426f49155cb19980bf6d
> src/master/detector/detector.cpp 1ebe5af4219a7e1ec1cbf22b440dd3ecaad4b4a9
> src/slave/slave.cpp 7564e8d39530794131dbbc928fcbc59fb65ef471
> src/tests/containerizer/docker_containerizer_tests.cpp 31d63b1f239055d82470ace9024b584a2096dce4
> src/tests/fetcher_cache_tests.cpp e5eee9bce56edacb74ad80ff859ddbc5048c73d0
> src/tests/hook_tests.cpp 237df8102941cd143c4d61016963e62a69c43382
> src/tests/persistent_volume_endpoints_tests.cpp ec8df33a3f0d4ad790d5cc753e1691c5517c39c0
>
> Diff: https://reviews.apache.org/r/56806/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>