You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/02/07 22:16:15 UTC
Review Request 56409: Enabled flag parsing of the 'Environment'
protobuf.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56409/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Kevin Klues.
Bugs: MESOS-7027
https://issues.apache.org/jira/browse/MESOS-7027
Repository: mesos
Description
-------
This adds 'mesos::Environment' to the template specializations
required for stout flags to parse the protobuf directly.
Diffs
-----
include/mesos/type_utils.hpp 632a7e53b1604a6234ed231eaedf1efb2eafde5f
src/common/parse.hpp 1dca9ba4ed4ff2163193ab6432b5b017d2be787e
src/common/type_utils.cpp 516d3094ef50aa368ec61c2c784f38b393c7e24a
Diff: https://reviews.apache.org/r/56409/diff/
Testing
-------
Testing later in the chain.
Thanks,
Joseph Wu
Re: Review Request 56409: Enabled flag parsing of the 'Environment'
protobuf.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56409/#review164586
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 7, 2017, 10:16 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56409/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 10:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Kevin Klues.
>
>
> Bugs: MESOS-7027
> https://issues.apache.org/jira/browse/MESOS-7027
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds 'mesos::Environment' to the template specializations
> required for stout flags to parse the protobuf directly.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp 632a7e53b1604a6234ed231eaedf1efb2eafde5f
> src/common/parse.hpp 1dca9ba4ed4ff2163193ab6432b5b017d2be787e
> src/common/type_utils.cpp 516d3094ef50aa368ec61c2c784f38b393c7e24a
>
> Diff: https://reviews.apache.org/r/56409/diff/
>
>
> Testing
> -------
>
> Testing later in the chain.
>
>
> Thanks,
>
> Joseph Wu
>
>