You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/02/04 17:49:06 UTC

Review Request 56308: Modified active containers key to be `TaskID` in the default executor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56308/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-6296
    https://issues.apache.org/jira/browse/MESOS-6296


Repository: mesos


Description
-------

We have more occurences of look up by `TaskID` then the other way
around. Hence, modified the active containers hashmap to be keyed
on `TaskID` instead.


Diffs
-----

  src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3 

Diff: https://reviews.apache.org/r/56308/diff/


Testing
-------

make check


Thanks,

Anand Mazumdar


Re: Review Request 56308: Modified active containers key to be `TaskID` in the default executor.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56308/#review164418
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Feb. 4, 2017, 5:49 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56308/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2017, 5:49 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-6296
>     https://issues.apache.org/jira/browse/MESOS-6296
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We have more occurences of look up by `TaskID` then the other way
> around. Hence, modified the active containers hashmap to be keyed
> on `TaskID` instead.
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3 
> 
> Diff: https://reviews.apache.org/r/56308/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>