You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/18 03:00:41 UTC
Re: Review Request 56619: Updated 'Files' handlers to use
'AuthenticationContext'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56619/
-----------------------------------------------------------
(Updated Feb. 18, 2017, 3 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Split endpoint changes into 3 separate patches.
Summary (updated)
-----------------
Updated 'Files' handlers to use 'AuthenticationContext'.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description (updated)
-------
This patch updates the HTTP endpoint handlers in the
Mesos `Files` process to accept an `AuthenticationContext`
instead of an `Option<string>& principal`.
Diffs (updated)
-----
src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e
src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a
Diff: https://reviews.apache.org/r/56619/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56619: Updated 'Files' handlers to use
'AuthenticationContext'.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56619/#review166883
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Feb. 25, 2017, 12:06 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56619/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2017, 12:06 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> Mesos `Files` process to accept an `AuthenticationContext`
> instead of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e
> src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a
>
> Diff: https://reviews.apache.org/r/56619/diff/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56619: Updated 'Files' handlers to use the
'Principal' type.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56619/#review167901
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 28, 2017, 6:32 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56619/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 6:32 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> Mesos `Files` process to accept the `Principal` type
> instead of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e
> src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a
>
>
> Diff: https://reviews.apache.org/r/56619/diff/8/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56619: Updated 'Files' handlers to use the
'Principal' type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56619/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 6:32 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP endpoint handlers in the
Mesos `Files` process to accept the `Principal` type
instead of an `Option<string>& principal`.
Diffs (updated)
-----
src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e
src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a
Diff: https://reviews.apache.org/r/56619/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56619: Updated 'Files' handlers to use the
'Principal' type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56619/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 6:34 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Changed 'AuthenticationContext' to 'Principal'.
Summary (updated)
-----------------
Updated 'Files' handlers to use the 'Principal' type.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description (updated)
-------
This patch updates the HTTP endpoint handlers in the
Mesos `Files` process to accept the `Principal` type
instead of an `Option<string>& principal`.
Diffs (updated)
-----
src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e
src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a
Diff: https://reviews.apache.org/r/56619/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56619: Updated 'Files' handlers to use
'AuthenticationContext'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56619/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 11:06 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP endpoint handlers in the
Mesos `Files` process to accept an `AuthenticationContext`
instead of an `Option<string>& principal`.
Diffs (updated)
-----
src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e
src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a
Diff: https://reviews.apache.org/r/56619/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56619: Updated 'Files' handlers to use
'AuthenticationContext'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56619/#review166634
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 22, 2017, 1:17 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56619/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 1:17 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> Mesos `Files` process to accept an `AuthenticationContext`
> instead of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e
> src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a
>
> Diff: https://reviews.apache.org/r/56619/diff/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56619: Updated 'Files' handlers to use
'AuthenticationContext'.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56619/
-----------------------------------------------------------
(Updated Feb. 22, 2017, 1:17 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Changed `context` to `authContext`.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the HTTP endpoint handlers in the
Mesos `Files` process to accept an `AuthenticationContext`
instead of an `Option<string>& principal`.
Diffs (updated)
-----
src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e
src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a
Diff: https://reviews.apache.org/r/56619/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56619: Updated 'Files' handlers to use
'AuthenticationContext'.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56619/#review166119
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Feb. 17, 2017, 7 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56619/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2017, 7 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the HTTP endpoint handlers in the
> Mesos `Files` process to accept an `AuthenticationContext`
> instead of an `Option<string>& principal`.
>
>
> Diffs
> -----
>
> src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e
> src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a
>
> Diff: https://reviews.apache.org/r/56619/diff/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>