You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/02/07 16:43:38 UTC
Review Request 56392: Tightened test expecations in
reservation-related tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Repository: mesos
Description
-------
This change makes expected error strings in reservation
validation-related tests explicit. This is to make sure that the
observed errors match the expected ones.
Diffs
-----
src/tests/master_validation_tests.cpp 1f833aa8d6cacbd7bf502fb66c556e4e3d4f79e2
Diff: https://reviews.apache.org/r/56392/diff/
Testing
-------
make check (OS X)
Thanks,
Benjamin Bannier
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/#review164625
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55461, 56391, 55462, 56392]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 7, 2017, 4:43 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56392/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 4:43 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change makes expected error strings in reservation
> validation-related tests explicit. This is to make sure that the
> observed errors match the expected ones.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 1f833aa8d6cacbd7bf502fb66c556e4e3d4f79e2
>
> Diff: https://reviews.apache.org/r/56392/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Feb. 11, 2017, 1:02 a.m., Benjamin Mahler wrote:
> > src/tests/master_validation_tests.cpp, line 428
> > <https://reviews.apache.org/r/56392/diff/3/?file=1629535#file1629535line428>
> >
> > Not yours, but we should take the backticks out the log message in a follow up.
Appended that follow-up to this chain, https://reviews.apache.org/r/56601/.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/#review165210
-----------------------------------------------------------
On Feb. 13, 2017, 4:38 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56392/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 4:38 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change makes expected error strings in reservation
> validation-related tests explicit. This is to make sure that the
> observed errors match the expected ones.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
>
> Diff: https://reviews.apache.org/r/56392/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/#review165210
-----------------------------------------------------------
Looks good, you'll need to rebase this after you update your previous patch.
src/tests/master_validation_tests.cpp (line 428)
<https://reviews.apache.org/r/56392/#comment237027>
Not yours, but we should take the backticks out the log message in a follow up.
- Benjamin Mahler
On Feb. 10, 2017, 3:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56392/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change makes expected error strings in reservation
> validation-related tests explicit. This is to make sure that the
> observed errors match the expected ones.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 0c2649089d7fd29eb021ac75c71e6a74368577dc
>
> Diff: https://reviews.apache.org/r/56392/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/#review165897
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Feb. 16, 2017, 10:24 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56392/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 10:24 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change makes expected error strings in reservation
> validation-related tests explicit. This is to make sure that the
> observed errors match the expected ones.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 83c88ae3a1f54eab29de79c0f34ade0cdb410341
>
> Diff: https://reviews.apache.org/r/56392/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/
-----------------------------------------------------------
(Updated Feb. 16, 2017, 11:24 a.m.)
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This change makes expected error strings in reservation
validation-related tests explicit. This is to make sure that the
observed errors match the expected ones.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 83c88ae3a1f54eab29de79c0f34ade0cdb410341
Diff: https://reviews.apache.org/r/56392/diff/
Testing
-------
make check (OS X)
Thanks,
Benjamin Bannier
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/#review165803
-----------------------------------------------------------
This will need a rebase since I did a few simplifications of the tests before committing the previous patch.
- Benjamin Mahler
On Feb. 14, 2017, 1:47 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56392/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 1:47 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change makes expected error strings in reservation
> validation-related tests explicit. This is to make sure that the
> observed errors match the expected ones.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
>
> Diff: https://reviews.apache.org/r/56392/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 2:47 a.m.)
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This change makes expected error strings in reservation
validation-related tests explicit. This is to make sure that the
observed errors match the expected ones.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
Diff: https://reviews.apache.org/r/56392/diff/
Testing
-------
make check (OS X)
Thanks,
Benjamin Bannier
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/
-----------------------------------------------------------
(Updated Feb. 14, 2017, 1:30 a.m.)
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This change makes expected error strings in reservation
validation-related tests explicit. This is to make sure that the
observed errors match the expected ones.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
Diff: https://reviews.apache.org/r/56392/diff/
Testing
-------
make check (OS X)
Thanks,
Benjamin Bannier
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/
-----------------------------------------------------------
(Updated Feb. 13, 2017, 4:38 p.m.)
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This change makes expected error strings in reservation
validation-related tests explicit. This is to make sure that the
observed errors match the expected ones.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
Diff: https://reviews.apache.org/r/56392/diff/
Testing
-------
make check (OS X)
Thanks,
Benjamin Bannier
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/#review165203
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55461, 56391, 55462, 56392]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 10, 2017, 3:16 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56392/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2017, 3:16 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change makes expected error strings in reservation
> validation-related tests explicit. This is to make sure that the
> observed errors match the expected ones.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 0c2649089d7fd29eb021ac75c71e6a74368577dc
>
> Diff: https://reviews.apache.org/r/56392/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/
-----------------------------------------------------------
(Updated Feb. 10, 2017, 4:16 p.m.)
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Changes
-------
Rebased.
Repository: mesos
Description
-------
This change makes expected error strings in reservation
validation-related tests explicit. This is to make sure that the
observed errors match the expected ones.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 0c2649089d7fd29eb021ac75c71e6a74368577dc
Diff: https://reviews.apache.org/r/56392/diff/
Testing
-------
make check (OS X)
Thanks,
Benjamin Bannier
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/#review164699
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55461, 56391, 55462, 56392]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 8, 2017, 11:41 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56392/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2017, 11:41 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change makes expected error strings in reservation
> validation-related tests explicit. This is to make sure that the
> observed errors match the expected ones.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 51185031cb67e64cd69ec6ce1c8f722a0c349970
>
> Diff: https://reviews.apache.org/r/56392/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 56392: Tightened test expecations in
reservation-related tests.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56392/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 12:41 p.m.)
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Repository: mesos
Description
-------
This change makes expected error strings in reservation
validation-related tests explicit. This is to make sure that the
observed errors match the expected ones.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 51185031cb67e64cd69ec6ce1c8f722a0c349970
Diff: https://reviews.apache.org/r/56392/diff/
Testing
-------
make check (OS X)
Thanks,
Benjamin Bannier