You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/02/01 18:40:10 UTC
Re: Review Request 56086: Simplified AppC provisioner cache keys
comparison.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56086/#review163849
-----------------------------------------------------------
Ship it!
LGTM!
- Gilbert Song
On Jan. 30, 2017, 9:27 a.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56086/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2017, 9:27 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Manual elements searching is not required since `std::map` is ordered. Replaced it with standard `operator==` that checks maps sizes and does linear element by element comparison.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/appc/cache.cpp fed5ae97419d5eb9611a6fd1ade1bbed7ed440a2
>
> Diff: https://reviews.apache.org/r/56086/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Ilya Pronin
>
>