You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jeff Malnick <ma...@gmail.com> on 2017/02/07 02:14:02 UTC
Review Request 56359: Add framework principal to the slave state
endpoint
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56359/
-----------------------------------------------------------
Review request for mesos and Adam B.
Bugs: MESOS-7071
https://issues.apache.org/jira/browse/MESOS-7071
Repository: mesos
Description
-------
This commit adds the framework principal to the slave state endpoint. The documentation for the agent state API needs to be updated to reflect this change.
Diffs
-----
src/slave/http.cpp d68c9adc1db43c2e853c8b2290705fdc7739d45c
Diff: https://reviews.apache.org/r/56359/diff/
Testing
-------
Tests are in progress.
Thanks,
Jeff Malnick
Re: Review Request 56359: Add framework principal to the slave state
endpoint
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56359/#review164484
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56359]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 7, 2017, 2:14 a.m., Jeff Malnick wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56359/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 2:14 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-7071
> https://issues.apache.org/jira/browse/MESOS-7071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds the framework principal to the slave state endpoint. The documentation for the agent state API needs to be updated to reflect this change.
>
>
> Diffs
> -----
>
> src/slave/http.cpp d68c9adc1db43c2e853c8b2290705fdc7739d45c
>
> Diff: https://reviews.apache.org/r/56359/diff/
>
>
> Testing
> -------
>
> Tests are in progress.
>
>
> Thanks,
>
> Jeff Malnick
>
>
Re: Review Request 56359: Add framework principal to the slave state
endpoint
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56359/#review164822
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Feb. 6, 2017, 6:14 p.m., Jeff Malnick wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56359/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 6:14 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-7071
> https://issues.apache.org/jira/browse/MESOS-7071
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds the framework principal to the slave state endpoint. The documentation for the agent state API needs to be updated to reflect this change.
>
>
> Diffs
> -----
>
> src/slave/http.cpp d68c9adc1db43c2e853c8b2290705fdc7739d45c
>
> Diff: https://reviews.apache.org/r/56359/diff/
>
>
> Testing
> -------
>
> Tests are in progress.
>
>
> Thanks,
>
> Jeff Malnick
>
>