You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/02/02 22:59:27 UTC
Review Request 56249: Cleaned up code style slightly in DRF sorter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56249/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Cleaned up code style slightly in DRF sorter.
Diffs
-----
src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56249/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56249: Cleaned up code style slightly in DRF
sorter.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56249/
-----------------------------------------------------------
(Updated Feb. 5, 2017, 10:01 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Use `foreach`
Repository: mesos
Description
-------
Cleaned up code style slightly in DRF sorter.
Diffs (updated)
-----
src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56249/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56249: Cleaned up code style slightly in DRF
sorter.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56249/#review164206
-----------------------------------------------------------
Fix it, then Ship it!
src/master/allocator/sorter/drf/sorter.cpp (line 390)
<https://reviews.apache.org/r/56249/#comment235857>
Do you not want to just go all the way to this?
```cpp
foreach (const Client& client, clients) {
// ...
}
```
Here and below.
- Michael Park
On Feb. 2, 2017, 2:59 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56249/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 2:59 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleaned up code style slightly in DRF sorter.
>
>
> Diffs
> -----
>
> src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
>
> Diff: https://reviews.apache.org/r/56249/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>