You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/28 07:07:37 UTC
Re: Review Request 56621: Updated Mesos tests to use the 'Principal'
type.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56621/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 7:07 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Changed 'AuthenticationContext' to 'Principal'.
Summary (updated)
-----------------
Updated Mesos tests to use the 'Principal' type.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description (updated)
-------
This patch updates the Mesos tests to use authenticated
handlers which accept the `Principal` type instead of an
`Option<string> principal`.
Diffs (updated)
-----
src/tests/files_tests.cpp 6c6353e406249f021803e83909415e9908ded28c
src/tests/http_authentication_tests.cpp 95f01c432f77d1a944dd78c343e21b310676417f
src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31
Diff: https://reviews.apache.org/r/56621/diff/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 56621: Updated Mesos tests to use the 'Principal'
type.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56621/#review167911
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 3, 2017, 6:51 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56621/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 6:51 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the Mesos tests to use authenticated
> handlers which accept the `Principal` type instead of an
> `Option<string> principal`.
>
>
> Diffs
> -----
>
> src/tests/files_tests.cpp 6c6353e406249f021803e83909415e9908ded28c
> src/tests/http_authentication_tests.cpp 95f01c432f77d1a944dd78c343e21b310676417f
> src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7
>
>
> Diff: https://reviews.apache.org/r/56621/diff/5/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56621: Updated Mesos tests to use the 'Principal'
type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56621/
-----------------------------------------------------------
(Updated March 3, 2017, 6:51 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates the Mesos tests to use authenticated
handlers which accept the `Principal` type instead of an
`Option<string> principal`.
Diffs (updated)
-----
src/tests/files_tests.cpp 6c6353e406249f021803e83909415e9908ded28c
src/tests/http_authentication_tests.cpp 95f01c432f77d1a944dd78c343e21b310676417f
src/tests/master_validation_tests.cpp 5a84c8d03cacd150ac61213a7c2d8613fd1780e7
Diff: https://reviews.apache.org/r/56621/diff/5/
Changes: https://reviews.apache.org/r/56621/diff/4-5/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 56621: Updated Mesos tests to use the 'Principal'
type.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56621/#review167080
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Feb. 28, 2017, 8:07 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56621/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 8:07 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the Mesos tests to use authenticated
> handlers which accept the `Principal` type instead of an
> `Option<string> principal`.
>
>
> Diffs
> -----
>
> src/tests/files_tests.cpp 6c6353e406249f021803e83909415e9908ded28c
> src/tests/http_authentication_tests.cpp 95f01c432f77d1a944dd78c343e21b310676417f
> src/tests/master_validation_tests.cpp 45254739e2a62fed7008ceada7a8f64bb9ee4e31
>
> Diff: https://reviews.apache.org/r/56621/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>