You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/02/08 02:53:40 UTC
Review Request 56422: Inject resource allocation info in agent for
received tasks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56422/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Bugs: MESOS-7077
https://issues.apache.org/jira/browse/MESOS-7077
Repository: mesos
Description
-------
Per MESOS-7077, the agent needs to inject allocation info into
tasks and executors coming from an old master to maintain the
invariant that all tasks and executors on the agent have an
allocation info.
Diffs
-----
src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8
src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7
Diff: https://reviews.apache.org/r/56422/diff/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 56422: Inject resource allocation info in agent for
received tasks.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56422/#review164802
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.cpp (line 1564)
<https://reviews.apache.org/r/56422/#comment236592>
`s/const ExecutorInfo& executorInfo_/ExecutorInfo executorInfo/`?
src/slave/slave.cpp (line 1577)
<https://reviews.apache.org/r/56422/#comment236593>
`foreach (Resource& resource, *resources) {`
src/slave/slave.cpp (lines 4603 - 4604)
<https://reviews.apache.org/r/56422/#comment236594>
Indent 4 spaces.
- Michael Park
On Feb. 7, 2017, 6:53 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56422/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 6:53 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-7077
> https://issues.apache.org/jira/browse/MESOS-7077
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Per MESOS-7077, the agent needs to inject allocation info into
> tasks and executors coming from an old master to maintain the
> invariant that all tasks and executors on the agent have an
> allocation info.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 92564ff8fff06d1cb17192d374d355b4bb7d39d8
> src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7
>
> Diff: https://reviews.apache.org/r/56422/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>