You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/02/28 06:31:24 UTC
Re: Review Request 56618: Updated common Mesos code to use the
'Principal' type.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56618/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 6:31 a.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Summary (updated)
-----------------
Updated common Mesos code to use the 'Principal' type.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates common Mesos HTTP-related helpers,
as well as the `authorization::Subject` protobuf
message, to make use of the `Principal` type instead
of an `Option<string> principal`.
Diffs
-----
include/mesos/authorizer/authorizer.proto 9cc75b0db17b2d0bab3f449f795cbf505c5b0f15
src/common/http.hpp 3d5ab59ddc4dce4d791c1b439f5e1459d1a724a4
src/common/http.cpp 5d75ecd8b6d2e288bebac50e7de738712858f74d
Diff: https://reviews.apache.org/r/56618/diff/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56618: Updated common Mesos code to use the
'Principal' type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56618/
-----------------------------------------------------------
(Updated March 3, 2017, 11:38 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates common Mesos HTTP-related helpers,
as well as the `authorization::Subject` protobuf
message, to make use of the `Principal` type instead
of an `Option<string> principal`.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.proto 9cc75b0db17b2d0bab3f449f795cbf505c5b0f15
src/common/http.hpp 3d5ab59ddc4dce4d791c1b439f5e1459d1a724a4
src/common/http.cpp 5d75ecd8b6d2e288bebac50e7de738712858f74d
Diff: https://reviews.apache.org/r/56618/diff/6/
Changes: https://reviews.apache.org/r/56618/diff/5-6/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann
Re: Review Request 56618: Updated common Mesos code to use the
'Principal' type.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56618/#review167891
-----------------------------------------------------------
Ship it!
src/common/http.hpp
Line 134 (original), 134 (patched)
<https://reviews.apache.org/r/56618/#comment239869>
s/callsites/call sites/ ?
- Vinod Kone
On March 3, 2017, 6:39 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56618/
> -----------------------------------------------------------
>
> (Updated March 3, 2017, 6:39 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates common Mesos HTTP-related helpers,
> as well as the `authorization::Subject` protobuf
> message, to make use of the `Principal` type instead
> of an `Option<string> principal`.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.proto 9cc75b0db17b2d0bab3f449f795cbf505c5b0f15
> src/common/http.hpp 3d5ab59ddc4dce4d791c1b439f5e1459d1a724a4
> src/common/http.cpp 5d75ecd8b6d2e288bebac50e7de738712858f74d
>
>
> Diff: https://reviews.apache.org/r/56618/diff/5/
>
>
> Testing
> -------
>
> Testing information can be found at the end of this review chain.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 56618: Updated common Mesos code to use the
'Principal' type.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56618/
-----------------------------------------------------------
(Updated March 3, 2017, 6:39 p.m.)
Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till Toenshoff, and Vinod Kone.
Changes
-------
Removed `createOptionalSubject()`.
Bugs: MESOS-7003
https://issues.apache.org/jira/browse/MESOS-7003
Repository: mesos
Description
-------
This patch updates common Mesos HTTP-related helpers,
as well as the `authorization::Subject` protobuf
message, to make use of the `Principal` type instead
of an `Option<string> principal`.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.proto 9cc75b0db17b2d0bab3f449f795cbf505c5b0f15
src/common/http.hpp 3d5ab59ddc4dce4d791c1b439f5e1459d1a724a4
src/common/http.cpp 5d75ecd8b6d2e288bebac50e7de738712858f74d
Diff: https://reviews.apache.org/r/56618/diff/5/
Changes: https://reviews.apache.org/r/56618/diff/4-5/
Testing
-------
Testing information can be found at the end of this review chain.
Thanks,
Greg Mann