You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2017/02/15 14:31:56 UTC
Re: Review Request 54784: Added authorization tests when trying to
attach to a container input.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 3:31 p.m.)
Review request for mesos and Adam B.
Summary (updated)
-----------------
Added authorization tests when trying to attach to a container input.
Bugs: MESOS-6886
https://issues.apache.org/jira/browse/MESOS-6886
Repository: mesos
Description
-------
Introduces a test where a principal is allowed to launch a container
session, but not to attach to its input, therefore its attempts should
fail.
Diffs
-----
src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
Diff: https://reviews.apache.org/r/54784/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 54784: Added authorization tests when trying to
attach to a container input.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/#review165717
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54783, 54784]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 15, 2017, 2:31 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54784/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 2:31 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6886
> https://issues.apache.org/jira/browse/MESOS-6886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduces a test where a principal is allowed to launch a container
> session, but not to attach to its input, therefore its attempts should
> fail.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
>
> Diff: https://reviews.apache.org/r/54784/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54784: Added authorization tests when trying to
attach to a container input.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/#review166121
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Feb. 15, 2017, 6:31 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54784/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 6:31 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6886
> https://issues.apache.org/jira/browse/MESOS-6886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduces a test where a principal is allowed to launch a container
> session, but not to attach to its input, therefore its attempts should
> fail.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
>
> Diff: https://reviews.apache.org/r/54784/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>