You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/02/15 15:35:53 UTC
Review Request 56711: Fixed fetcher to not pick up environment
variables it should not see.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56711/
-----------------------------------------------------------
Review request for mesos, Adam B and Benjamin Bannier.
Bugs: MESOS-6751
https://issues.apache.org/jira/browse/MESOS-6751
Repository: mesos
Description
-------
Fixed fetcher to not pick up environment variables it should not see.
Diffs
-----
src/slave/containerizer/fetcher.cpp 9ec38dc95dddfcd990369d0146986e20b15da1a0
Diff: https://reviews.apache.org/r/56711/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 56711: Fixed fetcher to not pick up environment
variables it should not see.
Posted by Till Toenshoff <to...@me.com>.
> On Feb. 15, 2017, 7:11 p.m., Benjamin Bannier wrote:
> > I think we agree that since we now have three instance of this same code in the codebase (already in `src/slave/container_loggers/lib_logrotate.cpp` and in `src/slave/containerizer/mesos/io/switchboard.cpp`), we have passed an arbitrary threshold to prioritize MESOS-6751 higher, cf. http://wiki.c2.com/?ThreeStrikesAndYouRefactor.
100%
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56711/#review165746
-----------------------------------------------------------
On Feb. 15, 2017, 3:35 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56711/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 3:35 p.m.)
>
>
> Review request for mesos, Adam B and Benjamin Bannier.
>
>
> Bugs: MESOS-6751
> https://issues.apache.org/jira/browse/MESOS-6751
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed fetcher to not pick up environment variables it should not see.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp 9ec38dc95dddfcd990369d0146986e20b15da1a0
>
> Diff: https://reviews.apache.org/r/56711/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 56711: Fixed fetcher to not pick up environment
variables it should not see.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56711/#review165746
-----------------------------------------------------------
Ship it!
I think we agree that since we now have three instance of this same code in the codebase (already in `src/slave/container_loggers/lib_logrotate.cpp` and in `src/slave/containerizer/mesos/io/switchboard.cpp`), we have passed an arbitrary threshold to prioritize MESOS-6751 higher, cf. http://wiki.c2.com/?ThreeStrikesAndYouRefactor.
- Benjamin Bannier
On Feb. 15, 2017, 4:35 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56711/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 4:35 p.m.)
>
>
> Review request for mesos, Adam B and Benjamin Bannier.
>
>
> Bugs: MESOS-6751
> https://issues.apache.org/jira/browse/MESOS-6751
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed fetcher to not pick up environment variables it should not see.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp 9ec38dc95dddfcd990369d0146986e20b15da1a0
>
> Diff: https://reviews.apache.org/r/56711/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 56711: Fixed fetcher to not pick up environment
variables it should not see.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56711/#review165738
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56711]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 15, 2017, 3:35 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56711/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 3:35 p.m.)
>
>
> Review request for mesos, Adam B and Benjamin Bannier.
>
>
> Bugs: MESOS-6751
> https://issues.apache.org/jira/browse/MESOS-6751
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed fetcher to not pick up environment variables it should not see.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.cpp 9ec38dc95dddfcd990369d0146986e20b15da1a0
>
> Diff: https://reviews.apache.org/r/56711/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 56711: Fixed fetcher to not pick up environment
variables it should not see.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56711/
-----------------------------------------------------------
(Updated Feb. 16, 2017, 1:30 a.m.)
Review request for mesos, Adam B and Benjamin Bannier.
Bugs: MESOS-6751 and MESOS-7133
https://issues.apache.org/jira/browse/MESOS-6751
https://issues.apache.org/jira/browse/MESOS-7133
Repository: mesos
Description
-------
Fixed fetcher to not pick up environment variables it should not see.
Diffs
-----
src/slave/containerizer/fetcher.cpp 9ec38dc95dddfcd990369d0146986e20b15da1a0
Diff: https://reviews.apache.org/r/56711/diff/
Testing
-------
make check
Thanks,
Till Toenshoff