You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/02/28 23:16:42 UTC
Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to
continue on an error.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53666/
-----------------------------------------------------------
(Updated Feb. 28, 2017, 11:16 p.m.)
Review request for mesos, Jie Yu and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6489
https://issues.apache.org/jira/browse/MESOS-6489
Repository: mesos
Description
-------
Added a `continueOnError` attribute to cgroups `Destroyer` to allow
cgroups cleanup to continue incase of any error. The linux launcher
continues cleanup of cgroups even if there is an error. However, if
the top level cgroup is actually removed, it treats it as a success.
Diffs (updated)
-----
src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d
src/linux/cgroups.cpp 3a853297eaccc86e55888da21f292f5e37c88733
src/slave/containerizer/mesos/linux_launcher.cpp a3409dc64435e002072b9b458a5fda0564214f28
Diff: https://reviews.apache.org/r/53666/diff/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to
continue on an error.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53666/#review175869
-----------------------------------------------------------
Patch looks great!
Reviews applied: [53666]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 23, 2017, 8:59 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53666/
> -----------------------------------------------------------
>
> (Updated May 23, 2017, 8:59 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-6489
> https://issues.apache.org/jira/browse/MESOS-6489
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `continueOnError` attribute to cgroups `Destroyer` to allow
> cgroups cleanup to continue incase of any error. The linux launcher
> continues cleanup of cgroups even if there is an error. However, if
> the top level cgroup is actually removed, it treats it as a success.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
> src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5
> src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931
>
>
> Diff: https://reviews.apache.org/r/53666/diff/3/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to
continue on an error.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53666/
-----------------------------------------------------------
(Updated May 23, 2017, 8:59 p.m.)
Review request for mesos, Jie Yu and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-6489
https://issues.apache.org/jira/browse/MESOS-6489
Repository: mesos
Description
-------
Added a `continueOnError` attribute to cgroups `Destroyer` to allow
cgroups cleanup to continue incase of any error. The linux launcher
continues cleanup of cgroups even if there is an error. However, if
the top level cgroup is actually removed, it treats it as a success.
Diffs (updated)
-----
src/linux/cgroups.hpp eaf0dcad0ed38c507564624f1647e0c731b8b433
src/linux/cgroups.cpp 334005abfc4ec9b20b7dc0212d852ba1f505dbb5
src/slave/containerizer/mesos/linux_launcher.cpp 1cea04edac8e0c4aea8c1c7d946b5065f3eac931
Diff: https://reviews.apache.org/r/53666/diff/3/
Changes: https://reviews.apache.org/r/53666/diff/2-3/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 53666: Refactor cgroups cleanup to allow cleanup to
continue on an error.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53666/#review167233
-----------------------------------------------------------
Patch looks great!
Reviews applied: [53666]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 28, 2017, 11:16 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53666/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 11:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-6489
> https://issues.apache.org/jira/browse/MESOS-6489
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a `continueOnError` attribute to cgroups `Destroyer` to allow
> cgroups cleanup to continue incase of any error. The linux launcher
> continues cleanup of cgroups even if there is an error. However, if
> the top level cgroup is actually removed, it treats it as a success.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp cfce09cb57501f2c988a8d997d7c6150280ed53d
> src/linux/cgroups.cpp 3a853297eaccc86e55888da21f292f5e37c88733
> src/slave/containerizer/mesos/linux_launcher.cpp a3409dc64435e002072b9b458a5fda0564214f28
>
>
> Diff: https://reviews.apache.org/r/53666/diff/2/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>