You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/02/02 22:59:43 UTC
Review Request 56251: Tightened assertions in sorter and allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56251/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Also replaced a mistaken comment.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 1d54f4c27428385bbcfc8e8bfb35aeea3a2cff7a
src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56251/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56251: Tightened assertions in sorter and
allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56251/#review164067
-----------------------------------------------------------
Bad patch!
Reviews applied: [56251, 56250, 56249, 56248, 56247, 56246, 56245]
Failed command: python support/apply-reviews.py -n -r 56251
Error:
2017-02-03 02:14:29 URL:https://reviews.apache.org/r/56251/diff/raw/ [2479/2479] -> "56251.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:432
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/16959/console
- Mesos Reviewbot
On Feb. 2, 2017, 10:59 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56251/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 10:59 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also replaced a mistaken comment.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 1d54f4c27428385bbcfc8e8bfb35aeea3a2cff7a
> src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
>
> Diff: https://reviews.apache.org/r/56251/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56251: Tightened assertions in sorter and
allocator.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56251/#review164251
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Feb. 3, 2017, 4:22 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56251/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 4:22 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also replaced a mistaken comment.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp e2cd82b737b73653eb59324778194c9eb5219a5b
> src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
>
> Diff: https://reviews.apache.org/r/56251/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56251: Tightened assertions in sorter and
allocator.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56251/
-----------------------------------------------------------
(Updated Feb. 4, 2017, 12:22 a.m.)
Review request for mesos and Michael Park.
Changes
-------
Replace `[]` with `at()`
Repository: mesos
Description
-------
Also replaced a mistaken comment.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp e2cd82b737b73653eb59324778194c9eb5219a5b
src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56251/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 56251: Tightened assertions in sorter and
allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56251/#review164164
-----------------------------------------------------------
Patch looks great!
Reviews applied: [56245, 56246, 56247, 56248, 56249, 56250, 56251]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 3, 2017, 5:57 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56251/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 5:57 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also replaced a mistaken comment.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 5f540569043df9d2bb75416c8c36bb4dd7bd68a1
> src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
>
> Diff: https://reviews.apache.org/r/56251/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 56251: Tightened assertions in sorter and
allocator.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56251/
-----------------------------------------------------------
(Updated Feb. 3, 2017, 5:57 p.m.)
Review request for mesos and Michael Park.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Also replaced a mistaken comment.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp 5f540569043df9d2bb75416c8c36bb4dd7bd68a1
src/master/allocator/sorter/drf/sorter.cpp 5681a5d78a7bdde820c3a8633d742d9d6412f1c7
Diff: https://reviews.apache.org/r/56251/diff/
Testing
-------
`make check`
Thanks,
Neil Conway